feat(core): extend the set of profiler events#59183
Closed
pkozlowski-opensource wants to merge 1 commit intoangular:mainfrom
Closed
feat(core): extend the set of profiler events#59183pkozlowski-opensource wants to merge 1 commit intoangular:mainfrom
pkozlowski-opensource wants to merge 1 commit intoangular:mainfrom
Conversation
JoostK
reviewed
Dec 13, 2024
ab7ebe4 to
6629318
Compare
This commit extends the set of events understood by the profiler integrated with the Angular time. The set got extended to account for the recently added functionality and mark entry point to the code execution points. The new set of events can be visualised by the Angular DevTools or other profiler integrations.
6629318 to
6c4b722
Compare
crisbeto
reviewed
Dec 13, 2024
crisbeto
approved these changes
Dec 14, 2024
| /** | ||
| * Corresponds to the point in time just before application bootstrap. | ||
| */ | ||
| BootstrapApplicationStart, |
Member
There was a problem hiding this comment.
re: #59183 (comment)
Maybe it's worth it to explicitly assign values to these enum fields
TemplateCreateStart = 0,
TemplateCreateEnd = 1,
...Not necessarily a blocker for this PR, but something to think about so that these event identifiers are more explicit instead of relying on implicit values assigned by field ordering
AleksanderBodurri
approved these changes
Dec 17, 2024
Contributor
|
This PR was merged into the repository by commit 22f191f. The changes were merged into the following branches: main |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
PrajaktaB27
pushed a commit
to PrajaktaB27/angular
that referenced
this pull request
Feb 7, 2025
This commit extends the set of events understood by the profiler integrated with the Angular time. The set got extended to account for the recently added functionality and mark entry point to the code execution points. The new set of events can be visualised by the Angular DevTools or other profiler integrations. PR Close angular#59183
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit extends the set of events understood by the profiler integrated with the Angular time. The set got extended to account for the recently added functionality and mark entry point to the code execution points.
The new set of events can be visualised by the Angular DevTools or other profiler integrations.