docs(core): remove redundant reference-manifests handwritten entries#59169
Closed
hawkgs wants to merge 1 commit intoangular:mainfrom
Closed
docs(core): remove redundant reference-manifests handwritten entries#59169hawkgs wants to merge 1 commit intoangular:mainfrom
hawkgs wants to merge 1 commit intoangular:mainfrom
Conversation
The handwritten entries are now included as part of `//packages/core:core_docs_extraction` it seems. So, they are no longer needed. On the contrary, they are causing duplicated entries in the generated manifest which are then reflected in the A.dev API reference. Fixes angular#59165
|
Deployed adev-preview for f620ba5 to: https://ng-dev-previews-fw--pr-angular-angular-59169-adev-prev-5q3rcd2m.web.app Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt. |
JeanMeche
approved these changes
Dec 12, 2024
AndrewKushnir
approved these changes
Dec 12, 2024
Contributor
Contributor
|
This PR was merged into the repository by commit 4c2cdd2. The changes were merged into the following branches: main, 19.0.x |
AndrewKushnir
pushed a commit
that referenced
this pull request
Dec 13, 2024
…59169) The handwritten entries are now included as part of `//packages/core:core_docs_extraction` it seems. So, they are no longer needed. On the contrary, they are causing duplicated entries in the generated manifest which are then reflected in the A.dev API reference. Fixes #59165 PR Close #59169
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
PrajaktaB27
pushed a commit
to PrajaktaB27/angular
that referenced
this pull request
Feb 7, 2025
…ngular#59169) The handwritten entries are now included as part of `//packages/core:core_docs_extraction` it seems. So, they are no longer needed. On the contrary, they are causing duplicated entries in the generated manifest which are then reflected in the A.dev API reference. Fixes angular#59165 PR Close angular#59169
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Duplicated entries in the manifest.
What is the new behavior?
The handwritten entries are now included as part of
//packages/core:core_docs_extractionit seems. So, they are no longer needed. On the contrary, they are causing duplicated entries in the generated manifest which are then reflected in the A.dev API reference.Let me know if I should keep the folder for future usage and drop only the JSON entries instead.
Fixes #59165
Does this PR introduce a breaking change?
Other information