Skip to content

refactor(core): add ENABLE_ROOT_COMPONENT_BOOTSTRAP token#59133

Closed
alan-agius4 wants to merge 1 commit intoangular:mainfrom
alan-agius4:DISABLE_COMPONENTS_BOOTSTRAP_TOKEN
Closed

refactor(core): add ENABLE_ROOT_COMPONENT_BOOTSTRAP token#59133
alan-agius4 wants to merge 1 commit intoangular:mainfrom
alan-agius4:DISABLE_COMPONENTS_BOOTSTRAP_TOKEN

Conversation

@alan-agius4
Copy link
Copy Markdown
Contributor

@alan-agius4 alan-agius4 commented Dec 10, 2024

Introduced the ENABLE_ROOT_COMPONENT_BOOTSTRAP token to control the bootstrapping of components during application initialization. This token is utilized by the Angular CLI in the @angular/ssr package, particularly during server-side rendering (SSR) when extracting routes.

When set to false, this token prevents the root component from being bootstrapped during SSR's route extraction phase, which is crucial for efficiently extracting routes without triggering component initialization. This mechanism separates the concerns of route extraction and component bootstrapping during SSR rendering, optimizing performance.

If not provided or set to true, the default behavior of bootstrapping the root component(s) during initialization is maintained.

Context: angular/angular-cli#29085

@alan-agius4 alan-agius4 marked this pull request as ready for review December 10, 2024 12:39
@angular-robot angular-robot bot added the area: core Issues related to the framework runtime label Dec 10, 2024
@ngbot ngbot bot added this to the Backlog milestone Dec 10, 2024
@alan-agius4 alan-agius4 changed the title refactor(core): add DISABLE_COMPONENTS_BOOTSTRAP token refactor(core): add DISABLE_COMPONENT_BOOTSTRAP token Dec 10, 2024
@alan-agius4 alan-agius4 added the target: patch This PR is targeted for the next patch release label Dec 10, 2024
@alan-agius4 alan-agius4 force-pushed the DISABLE_COMPONENTS_BOOTSTRAP_TOKEN branch from 318cae5 to ac6fb0e Compare December 10, 2024 12:41
@alan-agius4 alan-agius4 added area: server Issues related to server-side rendering action: review The PR is still awaiting reviews from at least one requested reviewer labels Dec 10, 2024
@angular-robot angular-robot bot added area: core Issues related to the framework runtime and removed area: core Issues related to the framework runtime labels Dec 10, 2024
@alan-agius4 alan-agius4 force-pushed the DISABLE_COMPONENTS_BOOTSTRAP_TOKEN branch from ac6fb0e to f286fd9 Compare December 10, 2024 12:43
@angular-robot angular-robot bot added area: core Issues related to the framework runtime and removed area: core Issues related to the framework runtime labels Dec 10, 2024
@alan-agius4 alan-agius4 force-pushed the DISABLE_COMPONENTS_BOOTSTRAP_TOKEN branch from f286fd9 to 9e0a7d8 Compare December 10, 2024 14:42
@angular-robot angular-robot bot added area: core Issues related to the framework runtime and removed area: core Issues related to the framework runtime labels Dec 10, 2024
@alan-agius4 alan-agius4 force-pushed the DISABLE_COMPONENTS_BOOTSTRAP_TOKEN branch from 9e0a7d8 to 794a41a Compare December 10, 2024 14:44
@angular-robot angular-robot bot added area: core Issues related to the framework runtime and removed area: core Issues related to the framework runtime labels Dec 10, 2024
@alan-agius4 alan-agius4 force-pushed the DISABLE_COMPONENTS_BOOTSTRAP_TOKEN branch from 794a41a to 4f2c59c Compare December 10, 2024 15:34
@angular-robot angular-robot bot added area: core Issues related to the framework runtime and removed area: core Issues related to the framework runtime labels Dec 10, 2024
@alan-agius4 alan-agius4 reopened this Dec 10, 2024
@angular-robot angular-robot bot added area: core Issues related to the framework runtime and removed area: core Issues related to the framework runtime labels Dec 10, 2024
@alan-agius4 alan-agius4 changed the title refactor(core): add DISABLE_COMPONENT_BOOTSTRAP token refactor(core): add ENABLE_ROOT_COMPONENT_BOOTSTRAP token Dec 10, 2024
@alan-agius4 alan-agius4 restored the DISABLE_COMPONENTS_BOOTSTRAP_TOKEN branch December 16, 2024 08:54
@alan-agius4
Copy link
Copy Markdown
Contributor Author

Turns out we need this approach due to angular/angular-cli#29131

@alan-agius4 alan-agius4 reopened this Dec 16, 2024
@angular-robot angular-robot bot added area: core Issues related to the framework runtime and removed area: core Issues related to the framework runtime labels Dec 16, 2024
@alan-agius4 alan-agius4 force-pushed the DISABLE_COMPONENTS_BOOTSTRAP_TOKEN branch from 9f2b64a to ba37fcd Compare December 16, 2024 11:49
@angular-robot angular-robot bot added area: core Issues related to the framework runtime and removed area: core Issues related to the framework runtime labels Dec 16, 2024
@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Dec 16, 2024
@alan-agius4 alan-agius4 removed the request for review from AndrewKushnir December 16, 2024 14:50
@alan-agius4 alan-agius4 added target: minor This PR is targeted for the next minor release and removed target: patch This PR is targeted for the next patch release labels Dec 16, 2024
Introduced the `ENABLE_ROOT_COMPONENT_BOOTSTRAP` token to control the bootstrapping of components during application initialization. This token is utilized by the Angular CLI in the `@angular/ssr` package, particularly during server-side rendering (SSR) when extracting routes.

When set to `false`, this token prevents the root component from being bootstrapped during SSR's route extraction phase, which is crucial for efficiently extracting routes without triggering component initialization. This mechanism separates the concerns of route extraction and component bootstrapping during SSR rendering, optimizing performance.

If not provided or set to `true`, the default behavior of bootstrapping the root component(s) during initialization is maintained.

Context: angular/angular-cli#29085
@alan-agius4 alan-agius4 force-pushed the DISABLE_COMPONENTS_BOOTSTRAP_TOKEN branch from ba37fcd to 042765f Compare December 16, 2024 14:56
@alan-agius4 alan-agius4 added target: patch This PR is targeted for the next patch release and removed target: minor This PR is targeted for the next minor release labels Dec 16, 2024
@angular-robot angular-robot bot added area: core Issues related to the framework runtime and removed area: core Issues related to the framework runtime labels Dec 16, 2024
@alan-agius4 alan-agius4 added target: minor This PR is targeted for the next minor release and removed target: patch This PR is targeted for the next patch release labels Dec 16, 2024
@AndrewKushnir
Copy link
Copy Markdown
Contributor

This PR was merged into the repository by commit 9e0b50b.

The changes were merged into the following branches: main

@alan-agius4 alan-agius4 deleted the DISABLE_COMPONENTS_BOOTSTRAP_TOKEN branch December 16, 2024 19:08
@angular-automatic-lock-bot
Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jan 16, 2025
PrajaktaB27 pushed a commit to PrajaktaB27/angular that referenced this pull request Feb 7, 2025
…59133)

Introduced the `ENABLE_ROOT_COMPONENT_BOOTSTRAP` token to control the bootstrapping of components during application initialization. This token is utilized by the Angular CLI in the `@angular/ssr` package, particularly during server-side rendering (SSR) when extracting routes.

When set to `false`, this token prevents the root component from being bootstrapped during SSR's route extraction phase, which is crucial for efficiently extracting routes without triggering component initialization. This mechanism separates the concerns of route extraction and component bootstrapping during SSR rendering, optimizing performance.

If not provided or set to `true`, the default behavior of bootstrapping the root component(s) during initialization is maintained.

Context: angular/angular-cli#29085

PR Close angular#59133
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker area: core Issues related to the framework runtime area: server Issues related to server-side rendering target: minor This PR is targeted for the next minor release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants