refactor(core): extract dirty and markForRefresh from the private ViewRef.#59122
Closed
JeanMeche wants to merge 1 commit intoangular:mainfrom
Closed
refactor(core): extract dirty and markForRefresh from the private ViewRef.#59122JeanMeche wants to merge 1 commit intoangular:mainfrom
dirty and markForRefresh from the private ViewRef.#59122JeanMeche wants to merge 1 commit intoangular:mainfrom
Conversation
82d35a6 to
72967f4
Compare
dirty and markForRefresh from the private ViewRef.
72967f4 to
cafb33f
Compare
cafb33f to
e15cec0
Compare
kirjs
approved these changes
Dec 10, 2024
Contributor
There was a problem hiding this comment.
do we need to update this comment now that we don't use the dirty prop anymore?
Member
Author
There was a problem hiding this comment.
I think we should keep it, requiresRefreshOrTraversal implies that we're checking for dirtiness.
e15cec0 to
794fcde
Compare
794fcde to
84f8bd7
Compare
… `ViewRef`. This allows better tree shaking from projects without the `element` package.
84f8bd7 to
245cf68
Compare
pkozlowski-opensource
approved these changes
Dec 19, 2024
Contributor
|
This PR was merged into the repository by commit e605433. The changes were merged into the following branches: main, 19.2.x |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows better tree shaking when not using the
elementpackage.