Skip to content

docs: correct typo in description of runTask method#59119

Closed
shayan-ghzl wants to merge 1 commit intoangular:mainfrom
shayan-ghzl:main
Closed

docs: correct typo in description of runTask method#59119
shayan-ghzl wants to merge 1 commit intoangular:mainfrom
shayan-ghzl:main

Conversation

@shayan-ghzl
Copy link
Copy Markdown
Contributor

@shayan-ghzl shayan-ghzl commented Dec 9, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.dev application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

  • Fixed a typo in the description of the runTask method.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@pullapprove pullapprove bot requested a review from kirjs December 9, 2024 20:37
@angular-robot angular-robot bot added the area: docs Related to the documentation label Dec 9, 2024
@ngbot ngbot bot added this to the Backlog milestone Dec 9, 2024
kirjs
kirjs approved these changes Dec 10, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@kirjs kirjs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing

@kirjs kirjs added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Dec 10, 2024
@AndrewKushnir AndrewKushnir added the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label Dec 12, 2024
@AndrewKushnir
Copy link
Copy Markdown
Contributor

AndrewKushnir commented Dec 12, 2024

@shayan-ghzl thanks for creating this PR. It looks like the lint CI check is failing due to the commit message, which contains incorrect scope (doc(fix):). Could you please update the commit message (using git commit --amend) to start with docs: instead? Than you.

@shayan-ghzl
Copy link
Copy Markdown
Contributor Author

shayan-ghzl commented Dec 13, 2024

@AndrewKushnir yes, of course
it's my pleasure
thank you for your kindness.

@AndrewKushnir AndrewKushnir changed the title docs(fix): correct typo in description of runTask method docs: correct typo in description of runTask method Dec 13, 2024
@AndrewKushnir AndrewKushnir removed the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label Dec 13, 2024
@AndrewKushnir
Copy link
Copy Markdown
Contributor

AndrewKushnir commented Dec 13, 2024

This PR was merged into the repository by commit 38b090a.

The changes were merged into the following branches: main, 19.0.x

AndrewKushnir pushed a commit that referenced this pull request Dec 13, 2024
@shayan-ghzl @AndrewKushnir
docs: correct typo in description of runTask method (#59119)
515a1fb 
PR Close #59119
@angular-automatic-lock-bot
Copy link
Copy Markdown

angular-automatic-lock-bot bot commented Jan 13, 2025

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jan 13, 2025
PrajaktaB27 pushed a commit to PrajaktaB27/angular that referenced this pull request Feb 7, 2025
@shayan-ghzl @PrajaktaB27
docs: correct typo in description of runTask method (angular#59119)
cf5d07c 
PR Close angular#59119
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@kirjs kirjs kirjs approved these changes

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker area: docs Related to the documentation target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

Backlog

Development

Successfully merging this pull request may close these issues.

3 participants

@shayan-ghzl @AndrewKushnir @kirjs