Empty the circular dependencies golden#59083
Closed
alxhub wants to merge 11 commits intoangular:mainfrom
Closed
Conversation
Use `import type` to break a phantom import cycle.
Use `import type` to break a phantom circular import in the output AST in the compiler.
Use `import type` to break a phantom circular import in the runtime definition of `ViewRef`.
Use `import type` to break a phantom circular import in iterable differs.
Use `import type` to break a phantom circular import in the DI code.
Use `import type` to break a phantom circular import in the runtime definition of `ComponentFactory` and `ComponentFactoryResolver`.
Use `import type` to break phantom circular imports in the runtime definitions of JIT decorators.
Use `import type` to break phantom circular imports in the runtime definitions of `LView` and `LContainer`.
Use `import type` to break phantom circular imports for `RouterOutletContext`.
Use `import type` to break phantom circular imports for router model definitions.
Contributor
|
As soon as this lands, I'll add the new goldens for rhombular dependencies. |
AndrewKushnir
approved these changes
Dec 5, 2024
Contributor
AndrewKushnir
left a comment
There was a problem hiding this comment.
Thanks for the cleanup 👍
Use `import type` to break phantom circular imports for the router navigation implementation.
b389cd2 to
e6261c6
Compare
Member
Author
Diamond dependencies are known to cause lots of problems, though... |
Member
Author
|
This PR was merged into the repository by commit 4a0c6cd. The changes were merged into the following branches: main, 19.0.x |
alxhub
added a commit
that referenced
this pull request
Dec 6, 2024
Use `import type` to break a phantom circular import in the output AST in the compiler. PR Close #59083
alxhub
added a commit
that referenced
this pull request
Dec 6, 2024
Use `import type` to break a phantom circular import in the runtime definition of `ViewRef`. PR Close #59083
alxhub
added a commit
that referenced
this pull request
Dec 6, 2024
) Use `import type` to break phantom circular imports in the runtime definitions of JIT decorators. PR Close #59083
alxhub
added a commit
that referenced
this pull request
Dec 6, 2024
Use `import type` to break phantom circular imports for `RouterOutletContext`. PR Close #59083
alxhub
added a commit
that referenced
this pull request
Dec 6, 2024
Use `import type` to break phantom circular imports for the router navigation implementation. PR Close #59083
alxhub
added a commit
that referenced
this pull request
Dec 6, 2024
Use `import type` to break a phantom circular import in the output AST in the compiler. PR Close #59083
alxhub
added a commit
that referenced
this pull request
Dec 6, 2024
Use `import type` to break a phantom circular import in the runtime definition of `ViewRef`. PR Close #59083
alxhub
added a commit
that referenced
this pull request
Dec 6, 2024
Use `import type` to break a phantom circular import in iterable differs. PR Close #59083
alxhub
added a commit
that referenced
this pull request
Dec 6, 2024
Use `import type` to break a phantom circular import in the DI code. PR Close #59083
alxhub
added a commit
that referenced
this pull request
Dec 6, 2024
Use `import type` to break a phantom circular import in the runtime definition of `ComponentFactory` and `ComponentFactoryResolver`. PR Close #59083
alxhub
added a commit
that referenced
this pull request
Dec 6, 2024
) Use `import type` to break phantom circular imports in the runtime definitions of JIT decorators. PR Close #59083
alxhub
added a commit
that referenced
this pull request
Dec 6, 2024
Use `import type` to break phantom circular imports for `RouterOutletContext`. PR Close #59083
alxhub
added a commit
that referenced
this pull request
Dec 6, 2024
Use `import type` to break phantom circular imports for the router navigation implementation. PR Close #59083
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
PrajaktaB27
pushed a commit
to PrajaktaB27/angular
that referenced
this pull request
Feb 7, 2025
…ngular#59083) Use `import type` to break a phantom import cycle. PR Close angular#59083
PrajaktaB27
pushed a commit
to PrajaktaB27/angular
that referenced
this pull request
Feb 7, 2025
) Use `import type` to break a phantom circular import in the output AST in the compiler. PR Close angular#59083
PrajaktaB27
pushed a commit
to PrajaktaB27/angular
that referenced
this pull request
Feb 7, 2025
) Use `import type` to break a phantom circular import in the runtime definition of `ViewRef`. PR Close angular#59083
PrajaktaB27
pushed a commit
to PrajaktaB27/angular
that referenced
this pull request
Feb 7, 2025
Use `import type` to break a phantom circular import in iterable differs. PR Close angular#59083
PrajaktaB27
pushed a commit
to PrajaktaB27/angular
that referenced
this pull request
Feb 7, 2025
Use `import type` to break a phantom circular import in the DI code. PR Close angular#59083
PrajaktaB27
pushed a commit
to PrajaktaB27/angular
that referenced
this pull request
Feb 7, 2025
…lar#59083) Use `import type` to break a phantom circular import in the runtime definition of `ComponentFactory` and `ComponentFactoryResolver`. PR Close angular#59083
PrajaktaB27
pushed a commit
to PrajaktaB27/angular
that referenced
this pull request
Feb 7, 2025
…ular#59083) Use `import type` to break phantom circular imports in the runtime definitions of JIT decorators. PR Close angular#59083
PrajaktaB27
pushed a commit
to PrajaktaB27/angular
that referenced
this pull request
Feb 7, 2025
…angular#59083) Use `import type` to break phantom circular imports in the runtime definitions of `LView` and `LContainer`. PR Close angular#59083
PrajaktaB27
pushed a commit
to PrajaktaB27/angular
that referenced
this pull request
Feb 7, 2025
…#59083) Use `import type` to break phantom circular imports for `RouterOutletContext`. PR Close angular#59083
PrajaktaB27
pushed a commit
to PrajaktaB27/angular
that referenced
this pull request
Feb 7, 2025
…gular#59083) Use `import type` to break phantom circular imports for router model definitions. PR Close angular#59083
PrajaktaB27
pushed a commit
to PrajaktaB27/angular
that referenced
this pull request
Feb 7, 2025
…lar#59083) Use `import type` to break phantom circular imports for the router navigation implementation. PR Close angular#59083
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Collection of commits which use
import typeto remove every existing circular dependency exception.