refactor(core): incremental hydration TODO cleanup#59032
Closed
thePunderWoman wants to merge 1 commit intoangular:mainfrom
Closed
refactor(core): incremental hydration TODO cleanup#59032thePunderWoman wants to merge 1 commit intoangular:mainfrom
thePunderWoman wants to merge 1 commit intoangular:mainfrom
Conversation
74d6f95 to
a47b453
Compare
a47b453 to
6895227
Compare
6895227 to
47397ab
Compare
47397ab to
d14b13c
Compare
d14b13c to
a5642d6
Compare
AndrewKushnir
approved these changes
Dec 11, 2024
a5642d6 to
418d576
Compare
This adds a few helper functions and ensures we call complete fns when error state is rendered. It also eliminates serialized views from being copied.
418d576 to
aa5c8ec
Compare
thePunderWoman
commented
Dec 11, 2024
| } | ||
|
|
||
| // Find matching view based on serialized defer block state. | ||
| // TODO(incremental-hydration): reconcile this logic with the regular logic that looks up |
Contributor
Author
There was a problem hiding this comment.
I looked through the other functions that look up dehydrated views, and based on my read, for the purposes of incremental hydration, this does encompass all the logic we need.
Contributor
Author
|
Caretaker note: Failing G3 tests are unrelated to this change. This is safe to merge. |
Contributor
|
This PR was merged into the repository by commit d8f08f4. The changes were merged into the following branches: main, 19.0.x |
AndrewKushnir
pushed a commit
that referenced
this pull request
Dec 12, 2024
This adds a few helper functions and ensures we call complete fns when error state is rendered. It also eliminates serialized views from being copied. PR Close #59032
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
PrajaktaB27
pushed a commit
to PrajaktaB27/angular
that referenced
this pull request
Feb 7, 2025
This adds a few helper functions and ensures we call complete fns when error state is rendered. It also eliminates serialized views from being copied. PR Close angular#59032
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a few helper functions and ensures we call complete fns when error state is rendered. It also eliminates serialized views from being copied.
PR Type
What kind of change does this PR introduce?
Does this PR introduce a breaking change?