Skip to content

docs: fix missing alert block styles in the API reference#59020

Closed
hawkgs wants to merge 1 commit intoangular:mainfrom
hawkgs:docs/fix-api-reference-alert-content
Closed

docs: fix missing alert block styles in the API reference#59020
hawkgs wants to merge 1 commit intoangular:mainfrom
hawkgs:docs/fix-api-reference-alert-content

Conversation

@hawkgs
Copy link
Copy Markdown
Member

@hawkgs hawkgs commented Dec 3, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.dev application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

It looks like the documentation still uses the legacy alert classes or to be more precise – they haven't been updated after the introduction of angular.dev which uses slightly different class names for the alert blocks.

What is the new behavior?

The alert blocks are now distinguishable from the rest of the content.

Does this PR introduce a breaking change?

  • Yes
  • No

@angular-robot angular-robot bot added the area: docs Related to the documentation label Dec 3, 2024
@ngbot ngbot bot added this to the Backlog milestone Dec 3, 2024
Substitute legacy alert classes with the new ones.
@hawkgs hawkgs force-pushed the docs/fix-api-reference-alert-content branch from d2753e4 to c61ee11 Compare December 3, 2024 16:04
@github-actions
Copy link
Copy Markdown

github-actions bot commented Dec 3, 2024

Deployed adev-preview for c61ee11 to: https://ng-dev-previews-fw--pr-angular-angular-59020-adev-prev-95zo7epp.web.app

Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt.

@AndrewKushnir AndrewKushnir added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note labels Dec 4, 2024
@AndrewKushnir
Copy link
Copy Markdown
Contributor

Caretaker note: low-risk PR (docs + ADEV styles), current set of approvals should be sufficient. Presubmit is not required as well (docs-only changes in the packages folder).

@pkozlowski-opensource
Copy link
Copy Markdown
Member

This PR was merged into the repository by commit 8d6ea5b.

The changes were merged into the following branches: main, 19.0.x

pkozlowski-opensource pushed a commit that referenced this pull request Dec 4, 2024
Substitute legacy alert classes with the new ones.

PR Close #59020
@hawkgs hawkgs deleted the docs/fix-api-reference-alert-content branch December 4, 2024 10:06
@angular-automatic-lock-bot
Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jan 4, 2025
PrajaktaB27 pushed a commit to PrajaktaB27/angular that referenced this pull request Feb 7, 2025
)

Substitute legacy alert classes with the new ones.

PR Close angular#59020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker adev: preview area: docs Related to the documentation merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants