refactor(core): Instantiate the ErrorHandler lazily.#58984
Closed
JeanMeche wants to merge 2 commits intoangular:mainfrom
Closed
refactor(core): Instantiate the ErrorHandler lazily.#58984JeanMeche wants to merge 2 commits intoangular:mainfrom
JeanMeche wants to merge 2 commits intoangular:mainfrom
Conversation
038badc to
0cf45a6
Compare
0cf45a6 to
2e9411d
Compare
Member
|
Note: I was looking into a similar refactor from a perf point of view - the observation being that we don't really need ErrorHandler until there is an actual error to handle. At the same time profiling real life applications (including adev) revealed that ErrorHandler can have non-trivial logic / take non-negligible amount of time to boot up. |
alxhub
approved these changes
Dec 3, 2024
2e9411d to
81608ce
Compare
pkozlowski-opensource
approved these changes
Dec 4, 2024
Member
|
FYI: it breaks some of the existing G3 tests: will require TGP and cleanup |
crisbeto
added a commit
to crisbeto/angular
that referenced
this pull request
Dec 20, 2024
In angular/components#30179 the CDK overlay started depending on the `Renderer2Factory`. Since the overlay is used in the `MatSnackbar` which is commonly used in error handlers, `Overlay` can end up being injected as a part of the app initialization. Because `AsyncAnimationRendererFactory` depends on the `ChangeDetectionScheduler`, it may cause a circular dependency. These changes inject the `ChangeDetectionScheduler` lazily to avoid the error. Note: this will also be resolved by angular#58984, but I decided to send it out, because: 1. angular#58984 seems to be stuck on some internal cleanup. 2. The `AsyncAnimationRendererFactory` doesn't need the `scheduler` eagerly anyway so the change is fairly safe. Fixes angular#59255.
josephperrott
pushed a commit
that referenced
this pull request
Dec 20, 2024
) In angular/components#30179 the CDK overlay started depending on the `Renderer2Factory`. Since the overlay is used in the `MatSnackbar` which is commonly used in error handlers, `Overlay` can end up being injected as a part of the app initialization. Because `AsyncAnimationRendererFactory` depends on the `ChangeDetectionScheduler`, it may cause a circular dependency. These changes inject the `ChangeDetectionScheduler` lazily to avoid the error. Note: this will also be resolved by #58984, but I decided to send it out, because: 1. #58984 seems to be stuck on some internal cleanup. 2. The `AsyncAnimationRendererFactory` doesn't need the `scheduler` eagerly anyway so the change is fairly safe. Fixes #59255. PR Close #59256
josephperrott
pushed a commit
to josephperrott/angular
that referenced
this pull request
Dec 20, 2024
In angular/components#30179 the CDK overlay started depending on the `Renderer2Factory`. Since the overlay is used in the `MatSnackbar` which is commonly used in error handlers, `Overlay` can end up being injected as a part of the app initialization. Because `AsyncAnimationRendererFactory` depends on the `ChangeDetectionScheduler`, it may cause a circular dependency. These changes inject the `ChangeDetectionScheduler` lazily to avoid the error. Note: this will also be resolved by angular#58984, but I decided to send it out, because: 1. angular#58984 seems to be stuck on some internal cleanup. 2. The `AsyncAnimationRendererFactory` doesn't need the `scheduler` eagerly anyway so the change is fairly safe. Fixes angular#59255.
josephperrott
pushed a commit
that referenced
this pull request
Dec 21, 2024
) In angular/components#30179 the CDK overlay started depending on the `Renderer2Factory`. Since the overlay is used in the `MatSnackbar` which is commonly used in error handlers, `Overlay` can end up being injected as a part of the app initialization. Because `AsyncAnimationRendererFactory` depends on the `ChangeDetectionScheduler`, it may cause a circular dependency. These changes inject the `ChangeDetectionScheduler` lazily to avoid the error. Note: this will also be resolved by #58984, but I decided to send it out, because: 1. #58984 seems to be stuck on some internal cleanup. 2. The `AsyncAnimationRendererFactory` doesn't need the `scheduler` eagerly anyway so the change is fairly safe. Fixes #59255. PR Close #59271
81ccc6a to
e7781a5
Compare
a326690 to
32ff162
Compare
This change prevents that user code in a custom `ErrorHandler` to run as part of `ApplicationRef`'s creation. fixes angular#58970
f491195 to
df1de5a
Compare
Contributor
df1de5a to
f709a4b
Compare
Contributor
|
@JeanMeche Switching to |
thePunderWoman
approved these changes
Apr 2, 2025
Contributor
|
This PR was merged into the repository by commit 1c1ad12. The changes were merged into the following branches: main |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change prevents that user code in a custom
ErrorHandlerto run as part ofApplicationRef's creation.fixes #58970