refactor(platform-browser) improve error message for UNEXPECTED_SYNTHETIC_PROPERTY#58983
Closed
DMezhenskyi wants to merge 1 commit intoangular:mainfrom
Closed
refactor(platform-browser) improve error message for UNEXPECTED_SYNTHETIC_PROPERTY#58983DMezhenskyi wants to merge 1 commit intoangular:mainfrom
DMezhenskyi wants to merge 1 commit intoangular:mainfrom
Conversation
pkozlowski-opensource
approved these changes
Dec 2, 2024
de36066 to
189c251
Compare
pkozlowski-opensource
requested changes
Dec 2, 2024
Member
pkozlowski-opensource
left a comment
There was a problem hiding this comment.
It looks like we've got tests verifying the error message (see failing CI jobs) - those will have to be updated as well.
AndrewKushnir
approved these changes
Dec 13, 2024
10b7e30 to
5bc4794
Compare
AndrewKushnir
approved these changes
Jan 6, 2025
Contributor
|
@DMezhenskyi could you please merge all commits into the first one (and make sure the commit message body has some content, as described in the |
…HETIC_PROPERTY Improve error message by adding instructions for enabling animations using standalone API.
5bc4794 to
fc7b34b
Compare
Contributor
Author
|
Hey @AndrewKushnir! Sure, I squashed commits and added the body to the commit message. Hopefully, this time everything will go OK. |
AndrewKushnir
approved these changes
Jan 7, 2025
pkozlowski-opensource
approved these changes
Jan 8, 2025
Contributor
|
This PR was merged into the repository by commit 00cc923. The changes were merged into the following branches: main, 19.0.x |
PrajaktaB27
pushed a commit
to PrajaktaB27/angular
that referenced
this pull request
Feb 7, 2025
…HETIC_PROPERTY (angular#58983) Improve error message by adding instructions for enabling animations using standalone API. PR Close angular#58983
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
Improved error message for
RuntimeErrorCode.UNEXPECTED_SYNTHETIC_PROPERTY. Added instructions for enabling animations using standalone API.What is the current behavior?
The error message contains instructions on how to configure animation only for Module-based app configuration.
Issue Number: N/A
What is the new behavior?
The error message contains instructions on how to configure animation for Standalone app configuration as well.
Does this PR introduce a breaking change?
Other information