Fixes for edge cases in inject migration#58959
Closed
crisbeto wants to merge 6 commits intoangular:mainfrom
Closed
Fixes for edge cases in inject migration#58959crisbeto wants to merge 6 commits intoangular:mainfrom
crisbeto wants to merge 6 commits intoangular:mainfrom
Conversation
Fixes that the inject migration was deleting the class' content if a property exists after the constructor that is being rewritten.
…ts in inject migration Fixes that the inject migration was sometimes producing invalid code if there are comments around the parameters.
Fixes that the inject migration would remove imports even if they're still used by classes that aren't being migrated.
Updates the inject migration to preserve type literals and tuple types, based on some internal feedback.
…injected Updates the inject migrations to skip over classes that have uninjectable class parameters.
…super is removed Fixes that in some cases the internal version of the migration was dropping code when all the statements after the `super` call are deleted.
devversion
approved these changes
Nov 29, 2024
Member
|
This PR was merged into the repository by commit 35165d1. The changes were merged into the following branches: main, 19.0.x |
pkozlowski-opensource
pushed a commit
that referenced
this pull request
Dec 2, 2024
Fixes that the inject migration was deleting the class' content if a property exists after the constructor that is being rewritten. PR Close #58959
pkozlowski-opensource
pushed a commit
that referenced
this pull request
Dec 2, 2024
Fixes that the inject migration would remove imports even if they're still used by classes that aren't being migrated. PR Close #58959
pkozlowski-opensource
pushed a commit
that referenced
this pull request
Dec 2, 2024
Fixes that the inject migration would remove imports even if they're still used by classes that aren't being migrated. PR Close #58959
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
PrajaktaB27
pushed a commit
to PrajaktaB27/angular
that referenced
this pull request
Feb 7, 2025
…lar#58959) Fixes that the inject migration was deleting the class' content if a property exists after the constructor that is being rewritten. PR Close angular#58959
PrajaktaB27
pushed a commit
to PrajaktaB27/angular
that referenced
this pull request
Feb 7, 2025
…ts in inject migration (angular#58959) Fixes that the inject migration was sometimes producing invalid code if there are comments around the parameters. PR Close angular#58959
PrajaktaB27
pushed a commit
to PrajaktaB27/angular
that referenced
this pull request
Feb 7, 2025
…lar#58959) Fixes that the inject migration would remove imports even if they're still used by classes that aren't being migrated. PR Close angular#58959
PrajaktaB27
pushed a commit
to PrajaktaB27/angular
that referenced
this pull request
Feb 7, 2025
…ns (angular#58959) Updates the inject migration to preserve type literals and tuple types, based on some internal feedback. PR Close angular#58959
PrajaktaB27
pushed a commit
to PrajaktaB27/angular
that referenced
this pull request
Feb 7, 2025
…injected (angular#58959) Updates the inject migrations to skip over classes that have uninjectable class parameters. PR Close angular#58959
PrajaktaB27
pushed a commit
to PrajaktaB27/angular
that referenced
this pull request
Feb 7, 2025
…super is removed (angular#58959) Fixes that in some cases the internal version of the migration was dropping code when all the statements after the `super` call are deleted. PR Close angular#58959
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Includes the following fixes for some edge cases in the
injectmigration:fix(migrations): class content being deleted in some edge cases
Fixes that the inject migration was deleting the class' content if a property exists after the constructor that is being rewritten.
fix(migrations): correctly strip away parameters surrounded by comments in inject migration
Fixes that the inject migration was sometimes producing invalid code if there are comments around the parameters.
fix(migrations): inject migration aggressively removing imports
Fixes that the inject migration would remove imports even if they're still used by classes that aren't being migrated.
fix(migrations): preserve type literals and tuples in inject migrations
Updates the inject migration to preserve type literals and tuple types, based on some internal feedback.
fix(migrations): don't migrate classes with parameters that can't be injected
Updates the inject migrations to skip over classes that have uninjectable class parameters.
fix(migrations): inject migration dropping code if everything except super is removed
Fixes that in some cases the internal version of the migration was dropping code when all the statements after the
supercall are deleted.