fix(platform-server): Warn user when transfer state happens more than…#58935
Closed
kirjs wants to merge 1 commit intoangular:mainfrom
Closed
fix(platform-server): Warn user when transfer state happens more than…#58935kirjs wants to merge 1 commit intoangular:mainfrom
kirjs wants to merge 1 commit intoangular:mainfrom
Conversation
c704f43 to
29e5d48
Compare
Contributor
|
@kirjs could you please update the commit message to include the following line at the end (separated by a new line)? This would automatically close the mentioned issue once this PR is merged. |
29e5d48 to
f3a5cd6
Compare
1448c6c to
ba291c7
Compare
AndrewKushnir
approved these changes
Dec 4, 2024
Contributor
AndrewKushnir
left a comment
There was a problem hiding this comment.
LGTM, just a couple minor comments.
Contributor
|
@kirjs could you please also merge all commits into one? The other 2 commits look mostly as addressing feedback vs independent commits that worth having in commit history. |
… once This can happen if server providers are provided more than twice. We detect it on the state transfer phase by flagging app id as transferred in a set. Resolves angular#58531
ba291c7 to
53d3ff7
Compare
AndrewKushnir
approved these changes
Dec 4, 2024
Contributor
|
This PR was merged into the repository by commit 300b141. The changes were merged into the following branches: main, 19.0.x |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
PrajaktaB27
pushed a commit
to PrajaktaB27/angular
that referenced
this pull request
Feb 7, 2025
… once (angular#58935) This can happen if server providers are provided more than twice. We detect it on the state transfer phase by flagging app id as transferred in a set. Resolves angular#58531 PR Close angular#58935
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… once
This can happen if server providers are provided more than twice. We detect it on the state transfer phase by flagging app id as transferred in a set.