fix(core): Explicitly manage TracingSnapshot lifecycle and dispose of it once it's been used. by arielbackenroth · Pull Request #58929 · angular/angular

arielbackenroth · 2024-11-27T12:54:17Z

PR Checklist

Please check if your PR fulfills the following requirements:

[ X] The commit message follows our guidelines: https://github.com/angular/angular/blob/main/CONTRIBUTING.md#commit
[X ] Tests for the changes have been added (for bug fixes / features)
[ X] Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

Fix for tracing service to explicitly manage lifecycle

[X ] Bugfix
Feature
Code style update (formatting, local variables)
Refactoring (no functional changes, no api changes)
Build related changes
CI related changes
Documentation content changes
angular.dev application / infrastructure changes
Other... Please describe:

What is the current behavior?

Currently our experimental implementation of this service fails because it attempts to run snapshots that have been previously resumed. Need to explicitly manage releasing ref counts and enable snapshots to be used multiple times.

Issue Number: N/A

What is the new behavior?

Have Angular explicitly call dispose to release resources (refcounts) by the tracing.

Does this PR introduce a breaking change?

Yes
[ X] No

Other information

google-cla · 2024-11-27T12:54:21Z

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

… it once it's been used. Provide a callback to the TracingService implementation when a Snapshot can be disposed. The underlying tracing implementation may use refcounting and needs to release resources to enable the trace to complete. While change detection uses the snapshot for exactly one callback, after render runs multiple hooks in the sequence so we need a more predictable way to indicate that the snapshot can be finalized.s

pkozlowski-opensource · 2024-11-27T17:11:16Z

This PR was merged into the repository by commit 3b76536.

The changes were merged into the following branches: main, 19.0.x

… it once it's been used. (#58929) Provide a callback to the TracingService implementation when a Snapshot can be disposed. The underlying tracing implementation may use refcounting and needs to release resources to enable the trace to complete. While change detection uses the snapshot for exactly one callback, after render runs multiple hooks in the sequence so we need a more predictable way to indicate that the snapshot can be finalized.s PR Close #58929

angular-automatic-lock-bot · 2024-12-28T00:11:25Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

pullapprove bot requested a review from alxhub November 27, 2024 12:54

angular-robot bot added the area: core Issues related to the framework runtime label Nov 27, 2024

ngbot bot added this to the Backlog milestone Nov 27, 2024

crisbeto requested review from crisbeto and removed request for alxhub November 27, 2024 13:36

arielbackenroth force-pushed the dispose branch from 01785c0 to bc47b73 Compare November 27, 2024 14:15