fix(core): Ensure _tick is always run within the TracingSnapshot.#58881
Closed
arielbackenroth wants to merge 1 commit intoangular:mainfrom
arielbackenroth:main
Closed
fix(core): Ensure _tick is always run within the TracingSnapshot.#58881arielbackenroth wants to merge 1 commit intoangular:mainfrom arielbackenroth:main
arielbackenroth wants to merge 1 commit intoangular:mainfrom
arielbackenroth:main
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
crisbeto
approved these changes
Nov 25, 2024
Fix a bug where calls to _tick are called without running through the snapshot. This helps ensure that all snapshots that are requested are resumed.
Contributor
|
This PR was merged into the repository by commit 785c611. The changes were merged into the following branches: main, 19.0.x |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Ensures that _tick will always run within a TracingSnapshot if one has been requested. _tick is run directly from zoneless_scheduling_impl.ts which bypasses tick().
Issue Number: N/A
What is the new behavior?
This ensures that all calls to _tick run within the Snapshot which enables to the underlying tracing implementation to release the snapshot.
Does this PR introduce a breaking change?
Other information