refactor(core): remove an unused field and invoke setActiveConsumer at the right time#58864
Closed
AndrewKushnir wants to merge 2 commits intoangular:mainfrom
Closed
refactor(core): remove an unused field and invoke setActiveConsumer at the right time#58864AndrewKushnir wants to merge 2 commits intoangular:mainfrom
setActiveConsumer at the right time#58864AndrewKushnir wants to merge 2 commits intoangular:mainfrom
Conversation
This commit removes an unused field in the `ApplicationRef` class. Most likely the usage of the field was removed earlier.
… the right time This commit updates the code of the `ɵɵdeferHydrateWhen` function to invoke the `setActiveConsumer` function at the right time (currently, we invoke it in the `finally` block, which is too late).
thePunderWoman
pushed a commit
that referenced
this pull request
Nov 25, 2024
This commit removes an unused field in the `ApplicationRef` class. Most likely the usage of the field was removed earlier. PR Close #58864
Contributor
|
This PR was merged into the repository by commit c56ec5e. The changes were merged into the following branches: main, 19.0.x |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains a couple minor commits:
refactor(core): remove unused field in
ApplicationRefclassThis commit removes an unused field in the
ApplicationRefclass. Most likely the usage of the field was removed earlier.refactor(core): invoke
setActiveConsumerinɵɵdeferHydrateWhenat the right timeThis commit updates the code of the
ɵɵdeferHydrateWhenfunction to invoke thesetActiveConsumerfunction at the right time (currently, we invoke it in thefinallyblock, which is too late).