-
Notifications
You must be signed in to change notification settings - Fork 27k
docs: angular dev v18 page issue fix #58848
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Deployed adev-preview for 5600cf9 to: https://ng-dev-previews-fw--pr-angular-angular-58848-adev-prev-og3vdfff.web.app Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt. |
JeanMeche
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change isn't correct, we'd like to have a difference background color for deprecated versions of our docs.
799c7ae to
5600cf9
Compare
adev-nav-primary--deprecated class is missing in this preview version. |
|
Oh my bad, you're right! |
|
@prasantht96 @JeanMeche This shows that it can't merge into |
@thePunderWoman I also noticed that the request for review from @bencodezen has been removed by @JeanMeche , so that should no longer be an obstacle. If the action: cleanup label can be removed, the PR should be good to merge. Please let me know if there’s anything else I need to address! |
|
Jessica was right, before she added the |
|
@JeanMeche Ah yeah, we did release a new version last week, didn't we? LTS is correct. |
|
This PR was merged into the repository by commit c6cec5e. The changes were merged into the following branches: 18.2.x |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |


PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Fixes #58838
Issue Number: #58838
What is the new behavior?
Changed background color for the Menu.
Does this PR introduce a breaking change?
Other information