Skip to content

Conversation

@prasantht96
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.dev application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Fixes #58838
Issue Number: #58838

What is the new behavior?

Changed background color for the Menu.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@pullapprove pullapprove bot requested a review from bencodezen November 24, 2024 05:57
@angular-robot angular-robot bot added the area: docs Related to the documentation label Nov 24, 2024
@ngbot ngbot bot added this to the Backlog milestone Nov 24, 2024
@github-actions
Copy link

github-actions bot commented Nov 24, 2024

Deployed adev-preview for 5600cf9 to: https://ng-dev-previews-fw--pr-angular-angular-58848-adev-prev-og3vdfff.web.app

Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt.

Copy link
Member

@JeanMeche JeanMeche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change isn't correct, we'd like to have a difference background color for deprecated versions of our docs.

@prasantht96
Copy link
Contributor Author

Deployed adev-preview for 5600cf9 to: https://ng-dev-previews-fw--pr-angular-angular-58848-adev-prev-og3vdfff.web.app

Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt.

adev-nav-primary--deprecated class is missing in this preview version.

@prasantht96
Copy link
Contributor Author

This change isn't correct, we'd like to have a difference background color for deprecated versions of our docs.

image
image

@JeanMeche JeanMeche added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Nov 25, 2024
@JeanMeche
Copy link
Member

Oh my bad, you're right!
I've added the PR to the merge queue, thank you for this !

@thePunderWoman
Copy link
Contributor

@prasantht96 @JeanMeche This shows that it can't merge into 18.2.x. I think you'll need to rebase and resolve any conflicts / re-push before we can merge.

@thePunderWoman thePunderWoman added action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews and removed action: merge The PR is ready for merge by the caretaker labels Nov 25, 2024
@JeanMeche JeanMeche removed the request for review from bencodezen November 25, 2024 15:31
@prasantht96
Copy link
Contributor Author

prasantht96 commented Nov 26, 2024

@prasantht96 @JeanMeche This shows that it can't merge into 18.2.x. I think you'll need to rebase and resolve any conflicts / re-push before we can merge.

@thePunderWoman
The branch was already rebased on 18.2.x, and there are no conflicts. The issue preventing the merge seems to be related to the action: cleanup label, which is currently blocking the process.

I also noticed that the request for review from @bencodezen has been removed by @JeanMeche , so that should no longer be an obstacle. If the action: cleanup label can be removed, the PR should be good to merge. Please let me know if there’s anything else I need to address!

@JeanMeche JeanMeche added target: lts This PR is targeting a version currently in long-term support and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews target: patch This PR is targeted for the next patch release labels Nov 26, 2024
@JeanMeche
Copy link
Member

Jessica was right, before she added the cleanup label there was a target issue. It should have been LTS as we're targetting the v18 branch. We should fine now.

@JeanMeche JeanMeche added the action: merge The PR is ready for merge by the caretaker label Nov 26, 2024
@thePunderWoman
Copy link
Contributor

@JeanMeche Ah yeah, we did release a new version last week, didn't we? LTS is correct.

thePunderWoman pushed a commit that referenced this pull request Nov 26, 2024
@thePunderWoman
Copy link
Contributor

This PR was merged into the repository by commit c6cec5e.

The changes were merged into the following branches: 18.2.x

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker adev: preview area: docs Related to the documentation target: lts This PR is targeting a version currently in long-term support

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants