Skip to content

fix(core): correctly perform lazy routes migration for components wit… #58796

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
JoostK wants to merge 1 commit into from
Closed

fix(core): correctly perform lazy routes migration for components wit… #58796

JoostK wants to merge 1 commit into from

Conversation

@JoostK
Copy link
Member

@JoostK JoostK commented Nov 21, 2024

…h additional decorators

This fixes an issue where the lazy-routes migration would crash for component classes a decorator without arguments in front of the @Component decorator (in particular, it needed to be the first decorator).

Fixes #58793

@JoostK
fix(core): correctly perform lazy routes migration for components wit…
b0491b7 
…h additional decorators

This fixes an issue where the lazy-routes migration would crash for component classes a
decorator without arguments in front of the `@Component` decorator (in particular, it needed
to be the first decorator).

Fixes angular#58793
@JoostK JoostK added action: review The PR is still awaiting reviews from at least one requested reviewer area: core Issues related to the framework runtime target: patch This PR is targeted for the next patch release area: migrations Issues related to `ng update`/`ng generate` migrations labels Nov 21, 2024
@ngbot ngbot bot added this to the Backlog milestone Nov 21, 2024
@pullapprove pullapprove bot requested a review from thePunderWoman November 21, 2024 13:57
@angular-robot angular-robot bot added area: core Issues related to the framework runtime and removed area: core Issues related to the framework runtime labels Nov 21, 2024
thePunderWoman
thePunderWoman approved these changes Nov 21, 2024
View reviewed changes
Copy link
Contributor

@thePunderWoman thePunderWoman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thePunderWoman thePunderWoman added action: presubmit The PR is in need of a google3 presubmit action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer action: presubmit The PR is in need of a google3 presubmit labels Nov 21, 2024
thePunderWoman pushed a commit that referenced this pull request Nov 21, 2024
@JoostK @thePunderWoman
fix(core): correctly perform lazy routes migration for components wit…
9971510 
…h additional decorators (#58796)

This fixes an issue where the lazy-routes migration would crash for component classes a
decorator without arguments in front of the `@Component` decorator (in particular, it needed
to be the first decorator).

Fixes #58793

PR Close #58796
@thePunderWoman
Copy link
Contributor

thePunderWoman commented Nov 21, 2024

This PR was merged into the repository by commit 21f757c.

The changes were merged into the following branches: main, 19.0.x

@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Dec 22, 2024

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@thePunderWoman thePunderWoman thePunderWoman approved these changes

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker area: core Issues related to the framework runtime area: migrations Issues related to `ng update`/`ng generate` migrations target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

Backlog

Development

Successfully merging this pull request may close these issues.

ng generate @angular/core:route-lazy-loading fails

2 participants

@JoostK @thePunderWoman