fix(forms): work around TypeScript 5.7 issue #58731
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adjusts the return type of `FormBuilder.group` to work around microsoft/TypeScript#60506.
alxhub
approved these changes
Nov 19, 2024
thePunderWoman
approved these changes
Nov 19, 2024
Contributor
thePunderWoman
left a comment
There was a problem hiding this comment.
reviewed-for: public-api
Member
Author
|
Passing TGP after one manual tweak. Will unblock this PR once the team accepts the fix. |
Contributor
|
This PR was merged into the repository by commit 4a18dc0. The changes were merged into the following branches: main, 19.0.x |
AndrewKushnir
pushed a commit
that referenced
this pull request
Nov 19, 2024
Adjusts the return type of `FormBuilder.group` to work around microsoft/TypeScript#60506. PR Close #58731
crisbeto
added a commit
to crisbeto/angular
that referenced
this pull request
Nov 20, 2024
Reworks the changes from angular#58731, because they didn't cover all use cases.
thePunderWoman
pushed a commit
that referenced
this pull request
Nov 21, 2024
thePunderWoman
pushed a commit
that referenced
this pull request
Nov 21, 2024
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjusts the return type of
FormBuilder.groupto work around microsoft/TypeScript#60506.