Skip to content

fix(core): Prevents race condition of cleanup for incremental hydration #58722

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
thePunderWoman wants to merge 1 commit into from
Closed

fix(core): Prevents race condition of cleanup for incremental hydration #58722

thePunderWoman wants to merge 1 commit into from

Conversation

@thePunderWoman
Copy link
Contributor

@thePunderWoman thePunderWoman commented Nov 18, 2024 •
edited
Loading

When hydrating a tree of blocks, this prevents cleanup from firing more than once per tree. It also ensures the cleanup happens after hydration has finished.

fixes #58690

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix

Does this PR introduce a breaking change?

  • Yes
  • No

@thePunderWoman thePunderWoman added action: review The PR is still awaiting reviews from at least one requested reviewer area: core Issues related to the framework runtime target: patch This PR is targeted for the next patch release labels Nov 18, 2024
@ngbot ngbot bot added this to the Backlog milestone Nov 18, 2024
@angular-robot angular-robot bot added area: core Issues related to the framework runtime and removed area: core Issues related to the framework runtime labels Nov 18, 2024
thePunderWoman
thePunderWoman commented Nov 18, 2024
View reviewed changes
@angular-robot angular-robot bot added area: core Issues related to the framework runtime and removed area: core Issues related to the framework runtime labels Nov 18, 2024
AndrewKushnir
AndrewKushnir reviewed Nov 18, 2024
View reviewed changes
@angular-robot angular-robot bot added area: core Issues related to the framework runtime and removed area: core Issues related to the framework runtime labels Nov 19, 2024
@angular-robot angular-robot bot added area: core Issues related to the framework runtime and removed area: core Issues related to the framework runtime labels Nov 20, 2024
@angular-robot angular-robot bot added area: core Issues related to the framework runtime and removed area: core Issues related to the framework runtime labels Nov 20, 2024
@ngbot ngbot bot modified the milestone: Backlog Nov 20, 2024
@angular-robot angular-robot bot added area: core Issues related to the framework runtime and removed area: core Issues related to the framework runtime labels Nov 20, 2024
@ngbot ngbot bot modified the milestone: Backlog Nov 20, 2024
@angular-robot angular-robot bot removed the area: core Issues related to the framework runtime label Nov 20, 2024
@angular-robot angular-robot bot added area: core Issues related to the framework runtime and removed area: core Issues related to the framework runtime labels Nov 21, 2024
@ngbot ngbot bot modified the milestone: Backlog Nov 21, 2024
@angular-robot angular-robot bot added area: core Issues related to the framework runtime and removed area: core Issues related to the framework runtime labels Nov 21, 2024
@ngbot ngbot bot modified the milestone: Backlog Nov 21, 2024
AndrewKushnir
AndrewKushnir approved these changes Nov 21, 2024
View reviewed changes
@angular-robot angular-robot bot added area: core Issues related to the framework runtime and removed area: core Issues related to the framework runtime labels Nov 21, 2024
@ngbot ngbot bot modified the milestone: Backlog Nov 21, 2024
@thePunderWoman
fix(core): Prevents race condition of cleanup for incremental hydration
30f0ecd 
When hydrating a tree of blocks, this prevents cleanup from firing more than once per tree. It also ensures the cleanup happens after hydration has finished.

fixes: angular#58690
@angular-robot angular-robot bot added area: core Issues related to the framework runtime and removed area: core Issues related to the framework runtime labels Nov 21, 2024
@ngbot ngbot bot modified the milestone: Backlog Nov 21, 2024
@thePunderWoman thePunderWoman added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Nov 21, 2024
thePunderWoman added a commit that referenced this pull request Nov 21, 2024
@thePunderWoman
fix(core): Prevents race condition of cleanup for incremental hydrati…
d3491c7 
…on (#58722)

When hydrating a tree of blocks, this prevents cleanup from firing more than once per tree. It also ensures the cleanup happens after hydration has finished.

fixes: #58690

PR Close #58722
@thePunderWoman
Copy link
Contributor Author

thePunderWoman commented Nov 21, 2024

This PR was merged into the repository by commit bd08d1d.

The changes were merged into the following branches: main, 19.0.x

@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Dec 22, 2024

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 22, 2024
@thePunderWoman thePunderWoman deleted the hydration-router branch March 6, 2025 20:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@AndrewKushnir AndrewKushnir AndrewKushnir approved these changes

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker area: core Issues related to the framework runtime target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

Backlog

Development

Successfully merging this pull request may close these issues.

After upgrading to RC2, links under defer blocks with control statement e.g. @if takes 2 clicks to navigate

2 participants

@thePunderWoman @AndrewKushnir