refactor(core): add REQUEST, RESPONSE_INIT and REQUEST_CONTEXT tokens#58669
Closed
AndrewKushnir wants to merge 1 commit intoangular:mainfrom
Closed
refactor(core): add REQUEST, RESPONSE_INIT and REQUEST_CONTEXT tokens#58669AndrewKushnir wants to merge 1 commit intoangular:mainfrom
REQUEST, RESPONSE_INIT and REQUEST_CONTEXT tokens#58669AndrewKushnir wants to merge 1 commit intoangular:mainfrom
Conversation
thePunderWoman
approved these changes
Nov 14, 2024
alan-agius4
approved these changes
Nov 14, 2024
88dbe7b to
cadeb1f
Compare
…tokens This commit introduces the `REQUEST`, `RESPONSE_INIT` and `REQUEST_CONTEXT` tokens, which will replace similar ones from https://github.com/angular/angular-cli/blob/28503186230b5e22b84499641d56c9c981fdab1d/packages/angular/ssr/tokens/src/tokens.ts, so those tokens would be imported in application code via `@angular/core` package.
cadeb1f to
66c8254
Compare
Contributor
Author
Contributor
Author
|
Caretaker note: the presubmit looks good, existing set of LGTMs should be sufficient (low-risk change). |
Contributor
Author
|
This PR was merged into the repository by commit a55341b. The changes were merged into the following branches: main, 19.0.x |
AndrewKushnir
added a commit
that referenced
this pull request
Nov 14, 2024
…tokens (#58669) This commit introduces the `REQUEST`, `RESPONSE_INIT` and `REQUEST_CONTEXT` tokens, which will replace similar ones from https://github.com/angular/angular-cli/blob/28503186230b5e22b84499641d56c9c981fdab1d/packages/angular/ssr/tokens/src/tokens.ts, so those tokens would be imported in application code via `@angular/core` package. PR Close #58669
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit introduces the
REQUEST,RESPONSE_INITandREQUEST_CONTEXTtokens, which will replace similar ones from https://github.com/angular/angular-cli/blob/28503186230b5e22b84499641d56c9c981fdab1d/packages/angular/ssr/tokens/src/tokens.ts, so those tokens would be imported in application code via@angular/corepackage.Does this PR introduce a breaking change?