Skip to content

Conversation

@thesmiler
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.dev application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

expired banner for Angular DevSat

Issue Number: N/A

What is the new behavior?

Banner for State of JS 2024 survey

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@pullapprove pullapprove bot requested a review from jelbourn November 14, 2024 09:32
@thesmiler thesmiler requested review from JeanMeche and removed request for jelbourn November 14, 2024 09:32
@angular-robot angular-robot bot added the area: docs Related to the documentation label Nov 14, 2024
@ngbot ngbot bot added this to the Backlog milestone Nov 14, 2024
@thesmiler thesmiler added the target: patch This PR is targeted for the next patch release label Nov 14, 2024
@github-actions
Copy link

Deployed adev-preview for b46bab6 to: https://ng-dev-previews-fw--pr-angular-angular-58649-adev-prev-8twdmi1q.web.app

Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt.

Copy link
Member

@JeanMeche JeanMeche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@JeanMeche JeanMeche added the action: merge The PR is ready for merge by the caretaker label Nov 14, 2024
@thePunderWoman thePunderWoman added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release and removed action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Nov 14, 2024
thePunderWoman pushed a commit that referenced this pull request Nov 14, 2024
thePunderWoman pushed a commit that referenced this pull request Nov 14, 2024
@thePunderWoman
Copy link
Contributor

This PR was merged into the repository by commit 8af0cd0.

The changes were merged into the following branches: main, 18.2.x, 19.0.x

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker adev: preview area: docs Related to the documentation target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants