Skip to content

refactor(migrations): typos in signal migration incompatibility reasons#58636

Closed
cexbrayat wants to merge 1 commit intoangular:mainfrom
cexbrayat:fix/incompatibility-dots
Closed

refactor(migrations): typos in signal migration incompatibility reasons#58636
cexbrayat wants to merge 1 commit intoangular:mainfrom
cexbrayat:fix/incompatibility-dots

Conversation

@cexbrayat
Copy link
Copy Markdown
Member

@cexbrayat cexbrayat commented Nov 13, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.dev application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

A dot was appearing in the middle of the comment for DerivedIsIncompatible. While at it, a dot was missing in ClassManuallyInstantiated.

What is the new behavior?

Fixes the typos.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@cexbrayat
refactor(migrations): typos in signal migration incompatibility reasons
c82088e 
A dot was appearing in the middle of the comment for `DerivedIsIncompatible`.
While at it, a dot was missing in `ClassManuallyInstantiated`.
@pullapprove pullapprove bot requested a review from AndrewKushnir November 13, 2024 16:53
@angular-robot angular-robot bot added the area: migrations Issues related to `ng update`/`ng generate` migrations label Nov 13, 2024
@ngbot ngbot bot added this to the Backlog milestone Nov 13, 2024
devversion
devversion approved these changes Nov 13, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@devversion devversion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@devversion devversion removed the request for review from AndrewKushnir November 13, 2024 22:04
@devversion devversion added action: merge The PR is ready for merge by the caretaker target: rc This PR is targeted for the next release-candidate labels Nov 13, 2024
thePunderWoman pushed a commit that referenced this pull request Nov 14, 2024
@cexbrayat @thePunderWoman
refactor(migrations): typos in signal migration incompatibility reaso…
715caea 
…ns (#58636)

A dot was appearing in the middle of the comment for `DerivedIsIncompatible`.
While at it, a dot was missing in `ClassManuallyInstantiated`.

PR Close #58636
@thePunderWoman
Copy link
Copy Markdown
Contributor

thePunderWoman commented Nov 14, 2024

This PR was merged into the repository by commit ecd107b.

The changes were merged into the following branches: main, 19.0.x

@angular-automatic-lock-bot
Copy link
Copy Markdown

angular-automatic-lock-bot bot commented Dec 15, 2024

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@devversion devversion devversion approved these changes

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker area: migrations Issues related to `ng update`/`ng generate` migrations target: rc This PR is targeted for the next release-candidate

Projects

None yet

Milestone

Backlog

Development

Successfully merging this pull request may close these issues.

3 participants

@cexbrayat @thePunderWoman @devversion