fix(migrations): include the output migration in the defaults of the signal migration#58635
Closed
cexbrayat wants to merge 1 commit intoangular:mainfrom
Closed
fix(migrations): include the output migration in the defaults of the signal migration#58635cexbrayat wants to merge 1 commit intoangular:mainfrom
cexbrayat wants to merge 1 commit intoangular:mainfrom
Conversation
…signal migration Running `ng g @angular/core:signals` prompts for the question on which migration to run and offers 3 options (inputs, outputs, queries). Running with `--defaults` skips the prompts, but only runs 2 of them. This fixes it by including the `outputs` migration in the default ones.
83993b5 to
e73a62a
Compare
devversion
approved these changes
Nov 13, 2024
thePunderWoman
pushed a commit
that referenced
this pull request
Nov 13, 2024
…signal migration (#58635) Running `ng g @angular/core:signals` prompts for the question on which migration to run and offers 3 options (inputs, outputs, queries). Running with `--defaults` skips the prompts, but only runs 2 of them. This fixes it by including the `outputs` migration in the default ones. PR Close #58635
Contributor
|
This PR was merged into the repository by commit 579f613. The changes were merged into the following branches: main, 19.0.x |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Running
ng g @angular/core:signalsprompts for the question on which migration to run and offers 3 options (inputs, outputs, queries). Running with--defaultsskips the prompts, but only runs 2 of them.What is the new behavior?
This fixes it by including the
outputsmigration in the default ones.Does this PR introduce a breaking change?
Other information