Skip to content

refactor(core): moves incremental hydration codebase to better locations#58616

Closed
thePunderWoman wants to merge 1 commit intoangular:mainfrom
thePunderWoman:more-cleanup
Closed

refactor(core): moves incremental hydration codebase to better locations#58616
thePunderWoman wants to merge 1 commit intoangular:mainfrom
thePunderWoman:more-cleanup

Conversation

@thePunderWoman
Copy link
Copy Markdown
Contributor

@thePunderWoman thePunderWoman commented Nov 12, 2024

This eliminates the extra incremental.ts codepath and moves its functions to appropriate locations. No code actually functionally changes. This just moves where the code is housed.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Refactoring (no functional changes, no api changes)

Does this PR introduce a breaking change?

  • Yes
  • No

@thePunderWoman thePunderWoman added action: review The PR is still awaiting reviews from at least one requested reviewer area: core Issues related to the framework runtime target: rc This PR is targeted for the next release-candidate labels Nov 12, 2024
@ngbot ngbot bot added this to the Backlog milestone Nov 12, 2024
@angular-robot angular-robot bot added area: core Issues related to the framework runtime and removed area: core Issues related to the framework runtime labels Nov 12, 2024
@angular-robot angular-robot bot added area: core Issues related to the framework runtime and removed area: core Issues related to the framework runtime labels Nov 12, 2024
@ngbot ngbot bot modified the milestone: Backlog Nov 12, 2024
@thePunderWoman
refactor(core): moves incremental hydration codebase to better locations
159b932 
This eliminates the extra incremental.ts codepath and moves its functions to appropriate locations.
@angular-robot angular-robot bot added area: core Issues related to the framework runtime and removed area: core Issues related to the framework runtime labels Nov 12, 2024
@AndrewKushnir AndrewKushnir removed the action: review The PR is still awaiting reviews from at least one requested reviewer label Nov 12, 2024
@thePunderWoman thePunderWoman added the action: merge The PR is ready for merge by the caretaker label Nov 12, 2024
thePunderWoman added a commit that referenced this pull request Nov 12, 2024
@thePunderWoman
refactor(core): moves incremental hydration codebase to better locati…
a5e7a02 
…ons (#58616)

This eliminates the extra incremental.ts codepath and moves its functions to appropriate locations.

PR Close #58616
@thePunderWoman
Copy link
Copy Markdown
Contributor Author

thePunderWoman commented Nov 12, 2024

This PR was merged into the repository by commit f3d9316.

The changes were merged into the following branches: main, 19.0.x

@angular-automatic-lock-bot
Copy link
Copy Markdown

angular-automatic-lock-bot bot commented Dec 13, 2024

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 13, 2024
@thePunderWoman thePunderWoman deleted the more-cleanup branch March 6, 2025 20:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@AndrewKushnir AndrewKushnir AndrewKushnir approved these changes

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker area: core Issues related to the framework runtime target: rc This PR is targeted for the next release-candidate

Projects

None yet

Milestone

Backlog

Development

Successfully merging this pull request may close these issues.

2 participants

@thePunderWoman @AndrewKushnir