Skip to content

fix(docs-infra): retain function keyword in API definitions #58561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
alan-agius4 wants to merge 1 commit into from
Closed

fix(docs-infra): retain function keyword in API definitions #58561

alan-agius4 wants to merge 1 commit into from

Conversation

@alan-agius4
Copy link
Contributor

@alan-agius4 alan-agius4 commented Nov 8, 2024

Before:

animate(
  timings: string | number,
  styles?: AnimationStyleMetadata | AnimationKeyframesSequenceMetadata | null
): AnimationAnimateMetadata;

Now:

function animate(
  timings: string | number,
  styles?: AnimationStyleMetadata | AnimationKeyframesSequenceMetadata | null
): AnimationAnimateMetadata;

@alan-agius4
fix(docs-infra): retain function keyword in API definitions
3b3af5d 
**Before:**
```ts
animate(
  timings: string | number,
  styles?: AnimationStyleMetadata | AnimationKeyframesSequenceMetadata | null
): AnimationAnimateMetadata;
```

**Now:**
```ts
function animate(
  timings: string | number,
  styles?: AnimationStyleMetadata | AnimationKeyframesSequenceMetadata | null
): AnimationAnimateMetadata;
```
@alan-agius4 alan-agius4 added action: review The PR is still awaiting reviews from at least one requested reviewer target: patch This PR is targeted for the next patch release labels Nov 8, 2024
@pullapprove pullapprove bot requested a review from AndrewKushnir November 8, 2024 09:09
@angular-robot angular-robot bot added the area: docs-infra Angular.dev application and infrastructure label Nov 8, 2024
@ngbot ngbot bot added this to the Backlog milestone Nov 8, 2024
@alan-agius4 alan-agius4 requested review from JeanMeche and removed request for AndrewKushnir November 8, 2024 09:10
@JeanMeche JeanMeche added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Nov 8, 2024
thePunderWoman pushed a commit that referenced this pull request Nov 8, 2024
@alan-agius4 @thePunderWoman
fix(docs-infra): retain function keyword in API definitions (#58561)
499b227 
**Before:**
```ts
animate(
  timings: string | number,
  styles?: AnimationStyleMetadata | AnimationKeyframesSequenceMetadata | null
): AnimationAnimateMetadata;
```

**Now:**
```ts
function animate(
  timings: string | number,
  styles?: AnimationStyleMetadata | AnimationKeyframesSequenceMetadata | null
): AnimationAnimateMetadata;
```

PR Close #58561
@thePunderWoman
Copy link
Contributor

thePunderWoman commented Nov 8, 2024

This PR was merged into the repository by commit c2a9b75.

The changes were merged into the following branches: main, 18.2.x, 19.0.x

thePunderWoman pushed a commit that referenced this pull request Nov 8, 2024
@alan-agius4 @thePunderWoman
fix(docs-infra): retain function keyword in API definitions (#58561)
3d8f827 
**Before:**
```ts
animate(
  timings: string | number,
  styles?: AnimationStyleMetadata | AnimationKeyframesSequenceMetadata | null
): AnimationAnimateMetadata;
```

**Now:**
```ts
function animate(
  timings: string | number,
  styles?: AnimationStyleMetadata | AnimationKeyframesSequenceMetadata | null
): AnimationAnimateMetadata;
```

PR Close #58561
@alan-agius4 alan-agius4 deleted the retain-fn-keyword branch November 8, 2024 17:28
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Dec 9, 2024

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@JeanMeche JeanMeche JeanMeche approved these changes

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker area: docs-infra Angular.dev application and infrastructure target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

Backlog

Development

Successfully merging this pull request may close these issues.

3 participants

@alan-agius4 @thePunderWoman @JeanMeche