Skip to content

Conversation

@alan-agius4
Copy link
Contributor

In TSDoc, we currently handle the @usageNotes annotation, but this is not a standard TSDoc tag. Instead, the @remarks annotation is the correct standard, which is used in the Angular CLI repo and on the SSR package.

This change ensures that @remarks is treated the same as @usageNotes during the transform process.

In TSDoc, we currently handle the `@usageNotes` annotation, but this is not a standard TSDoc tag. Instead, the `@remarks` annotation is the correct standard, which is used in the Angular CLI repo and on the SSR package.

This change ensures that `@remarks` is treated the same as `@usageNotes` during the transform process.
@alan-agius4 alan-agius4 added action: review The PR is still awaiting reviews from at least one requested reviewer target: patch This PR is targeted for the next patch release labels Nov 6, 2024
@pullapprove pullapprove bot requested a review from bencodezen November 6, 2024 10:26
@angular-robot angular-robot bot added area: docs Related to the documentation area: docs-infra Angular.dev application and infrastructure labels Nov 6, 2024
@ngbot ngbot bot added this to the Backlog milestone Nov 6, 2024
@alan-agius4 alan-agius4 requested review from josephperrott and removed request for bencodezen November 6, 2024 10:28
Copy link
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Nov 7, 2024
thePunderWoman pushed a commit that referenced this pull request Nov 7, 2024
In TSDoc, we currently handle the `@usageNotes` annotation, but this is not a standard TSDoc tag. Instead, the `@remarks` annotation is the correct standard, which is used in the Angular CLI repo and on the SSR package.

This change ensures that `@remarks` is treated the same as `@usageNotes` during the transform process.

PR Close #58523
thePunderWoman pushed a commit that referenced this pull request Nov 7, 2024
In TSDoc, we currently handle the `@usageNotes` annotation, but this is not a standard TSDoc tag. Instead, the `@remarks` annotation is the correct standard, which is used in the Angular CLI repo and on the SSR package.

This change ensures that `@remarks` is treated the same as `@usageNotes` during the transform process.

PR Close #58523
@thePunderWoman
Copy link
Contributor

This PR was merged into the repository by commit c5ce302.

The changes were merged into the following branches: main, 18.2.x, 19.0.x

@alan-agius4 alan-agius4 deleted the tsdocs-remarks branch November 7, 2024 16:55
josephperrott added a commit to josephperrott/angular that referenced this pull request Nov 7, 2024
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker area: docs Related to the documentation area: docs-infra Angular.dev application and infrastructure target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants