fix(core): avoid slow stringification when checking for duplicates in dev mode #58521
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… dev mode When we check for duplicates in dev mode, we end up stringifying an `LView` even if we don't report an error. This can be expensive in large views. These changes work around the issue by only generating the string when we have an error to throw. Fixes angular#58509.
pkozlowski-opensource
approved these changes
Nov 6, 2024
Member
|
This PR was merged into the repository by commit 90978de. The changes were merged into the following branches: main, 18.2.x, 19.0.x |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we check for duplicates in dev mode, we end up stringifying an
LVieweven if we don't report an error. This can be expensive in large views.These changes work around the issue by only generating the string when we have an error to throw.
Fixes #58509.