Skip to content

fix(migrations): flip the default standalone flag in route-lazy-loadi…#58474

Closed
eneajaho wants to merge 1 commit intoangular:mainfrom
eneajaho:fixes-route-lazy-loading
Closed

fix(migrations): flip the default standalone flag in route-lazy-loadi…#58474
eneajaho wants to merge 1 commit intoangular:mainfrom
eneajaho:fixes-route-lazy-loading

Conversation

@eneajaho
Copy link
Contributor

@eneajaho eneajaho commented Nov 1, 2024

…ng migration

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix

What is the current behavior?

Issue Number: #58473

What is the new behavior?

Now the migration will work fine even when the standalone flag is not there at all (v19 defaults to true)

Does this PR introduce a breaking change?

  • Yes
  • No

@pullapprove pullapprove bot requested a review from crisbeto November 1, 2024 19:43
@angular-robot angular-robot bot added the area: migrations Issues related to `ng update`/`ng generate` migrations label Nov 1, 2024
@ngbot ngbot bot added this to the Backlog milestone Nov 1, 2024
AndrewKushnir
AndrewKushnir approved these changes Nov 1, 2024
View reviewed changes
packages/core/schematics/ng-generate/route-lazy-loading/util.ts Outdated
Copy link
Contributor

@AndrewKushnir AndrewKushnir Nov 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the change, the code looks good 👍 I'd like to propose a followup refactoring (as a separate PR) to move this function into a common migration utils (and potentially add some tests for it), so that we can reuse it in existing (including this one) and new migrations.

@AndrewKushnir AndrewKushnir removed the request for review from crisbeto November 1, 2024 21:01
@AndrewKushnir AndrewKushnir added the target: rc This PR is targeted for the next release-candidate label Nov 1, 2024
@AndrewKushnir AndrewKushnir modified the milestones: Backlog, v19 final Nov 1, 2024
@AndrewKushnir AndrewKushnir added the action: presubmit The PR is in need of a google3 presubmit label Nov 1, 2024
@AndrewKushnir
Copy link
Contributor

AndrewKushnir commented Nov 1, 2024

Presubmit.

@eneajaho
fix(migrations): flip the default standalone flag in route-lazy-loadi…
732df24 
…ng migration

Before v19, the default value of the standalone flag was false, this code change flips the logic in the migration to make it true by default.
@eneajaho eneajaho force-pushed the fixes-route-lazy-loading branch from 9923a3e to 732df24 Compare November 1, 2024 21:10
@eneajaho
Copy link
Contributor Author

eneajaho commented Nov 1, 2024

Needed to force push to fix the lint error.

@AndrewKushnir AndrewKushnir added action: merge The PR is ready for merge by the caretaker merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note and removed action: presubmit The PR is in need of a google3 presubmit labels Nov 2, 2024
@AndrewKushnir
Copy link
Contributor

AndrewKushnir commented Nov 2, 2024

Caretaker note: presubmit looks good, this PR is ready for merge.

@pkozlowski-opensource
Copy link
Member

pkozlowski-opensource commented Nov 3, 2024

This PR was merged into the repository by commit 6819d6a.

The changes were merged into the following branches: main, 19.0.x

pkozlowski-opensource pushed a commit that referenced this pull request Nov 3, 2024
@eneajaho @pkozlowski-opensource
fix(migrations): flip the default standalone flag in route-lazy-loadi…
c5e676b 
…ng migration (#58474)

Before v19, the default value of the standalone flag was false, this code change flips the logic in the migration to make it true by default.

PR Close #58474
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Dec 4, 2024

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@AndrewKushnir AndrewKushnir AndrewKushnir approved these changes

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker area: migrations Issues related to `ng update`/`ng generate` migrations merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note target: rc This PR is targeted for the next release-candidate

Projects

None yet

Milestone

v19 final

Development

Successfully merging this pull request may close these issues.

3 participants

@eneajaho @AndrewKushnir @pkozlowski-opensource