Skip to content

fix(docs-infra): reduce margin-block-start from doc anchor headers #58431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
alan-agius4 wants to merge 1 commit into from
Closed

fix(docs-infra): reduce margin-block-start from doc anchor headers #58431

alan-agius4 wants to merge 1 commit into from

Conversation

@alan-agius4
Copy link
Contributor

@alan-agius4 alan-agius4 commented Oct 30, 2024 •
edited
Loading

This change reduces the spacing between headers, which is currently excessive.

Before
Screenshot 2024-10-30 at 12 43 59

Now
Screenshot 2024-10-30 at 19 06 50

@angular-robot angular-robot bot added the area: docs-infra Angular.dev application and infrastructure label Oct 30, 2024
@ngbot ngbot bot added this to the Backlog milestone Oct 30, 2024
@alan-agius4 alan-agius4 requested review from jelbourn and removed request for pkozlowski-opensource October 30, 2024 16:32
@alan-agius4 alan-agius4 added action: review The PR is still awaiting reviews from at least one requested reviewer target: patch This PR is targeted for the next patch release labels Oct 30, 2024
@github-actions
Copy link

github-actions bot commented Oct 30, 2024 •
edited
Loading

Deployed adev-preview for 663eed8 to: https://ng-dev-previews-fw--pr-angular-angular-58431-adev-prev-n3mg6yuj.web.app

Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt.

@jelbourn
Copy link
Member

jelbourn commented Oct 30, 2024

What do you think about setting 1rem or 0.75rem? I think with no margin at all there's not quite enough visual separation between section headings.

@alan-agius4
fix(docs-infra): reduce margin-block-start from doc anchor headers
663eed8 
This change reduces the spacing between headers, which is currently excessive.
@alan-agius4 alan-agius4 changed the title fix(docs-infra): remove margin-block-start from doc anchor headers fix(docs-infra): reduce margin-block-start from doc anchor headers Oct 30, 2024
@alan-agius4
Copy link
Contributor Author

alan-agius4 commented Oct 30, 2024

What do you think about setting 1rem or 0.75rem? I think with no margin at all there's not quite enough visual separation between section headings.

@jelbourn updated.

jelbourn
jelbourn approved these changes Oct 30, 2024
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Oct 30, 2024
@pkozlowski-opensource
Copy link
Member

pkozlowski-opensource commented Oct 31, 2024

This PR was merged into the repository by commit f04e606.

The changes were merged into the following branches: main, 18.2.x, 19.0.x

pkozlowski-opensource pushed a commit that referenced this pull request Oct 31, 2024
@alan-agius4 @pkozlowski-opensource
fix(docs-infra): reduce margin-block-start from doc anchor headers (#…
ea08690 
…58431)

This change reduces the spacing between headers, which is currently excessive.

PR Close #58431
pkozlowski-opensource pushed a commit that referenced this pull request Oct 31, 2024
@alan-agius4 @pkozlowski-opensource
fix(docs-infra): reduce margin-block-start from doc anchor headers (#…
5828585 
…58431)

This change reduces the spacing between headers, which is currently excessive.

PR Close #58431
@alan-agius4 alan-agius4 deleted the remove-margin branch October 31, 2024 09:29
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Dec 1, 2024

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jelbourn jelbourn jelbourn approved these changes

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker adev: preview area: docs-infra Angular.dev application and infrastructure target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

Backlog

Development

Successfully merging this pull request may close these issues.

3 participants

@alan-agius4 @jelbourn @pkozlowski-opensource