Skip to content

build: Update publish-build-artifacts to honor ORG #58408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Jordan-Hall wants to merge 1 commit into from
Closed

build: Update publish-build-artifacts to honor ORG #58408

Jordan-Hall wants to merge 1 commit into from

Conversation

@Jordan-Hall
Copy link
Contributor

@Jordan-Hall Jordan-Hall commented Oct 29, 2024 •
edited
Loading

Currently you pass in the ORG and it still tries to publish to Angular rather than your ow ORG repo that gets created

PR Type

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.dev application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Currently every time you run the sript it always look for angular org regardless of the ORG is set.

First time, you need to create the GitHub repositories:

$ export TOKEN=[get one from https://github.com/settings/tokens]
$ CREATE_REPOS=1 ./scripts/ci/publish-build-artifacts.sh [GitHub username]

For subsequent snapshots, just run:

$ ./scripts/ci/publish-build-artifacts.sh [GitHub username]

The above example on how to get start currently doesnt work

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

@pullapprove pullapprove bot requested a review from devversion October 29, 2024 13:22
@ngbot ngbot bot added this to the Backlog milestone Oct 29, 2024
devversion
devversion approved these changes Oct 29, 2024
View reviewed changes
Copy link
Member

@devversion devversion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but can you change the commit message to build: XX? devtools refers to the Chrome extension of Angular.

Also I think, this script is not really meant to be used by users of Angular; but it doesn't hurt fixing this

@devversion devversion added action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews target: patch This PR is targeted for the next patch release labels Oct 29, 2024
@Jordan-Hall
build: Update publish-build-artifacts to honor ORG
5add74d 
Currently you pass in the ORG and it still tries to publish to Angular rather than your ow ORG repo that gets created
@angular-robot angular-robot bot added the area: build & ci Related the build and CI infrastructure of the project label Oct 29, 2024
@Jordan-Hall Jordan-Hall changed the title fix(devtools): Update publish-build-artifacts to honor ORG build: Update publish-build-artifacts to honor ORG Oct 29, 2024
@devversion devversion added action: merge The PR is ready for merge by the caretaker and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Oct 29, 2024
@Jordan-Hall
Copy link
Contributor Author

Jordan-Hall commented Oct 29, 2024

LGTM, but can you change the commit message to build: XX? devtools refers to the Chrome extension of Angular.

Also I think, this script is not really meant to be used by users of Angular; but it doesn't hurt fixing this

Sorted. I know t not really meant to be used, but docs mentions it. But it also helped for experimenting authoring such as selectorless and automatic import i've been having fun with

https://github.com/Jordan-Hall/angular-selectorless-experimental/blob/auto-imports/src/main.ts

thePunderWoman pushed a commit that referenced this pull request Nov 1, 2024
@Jordan-Hall @thePunderWoman
build: Update publish-build-artifacts to honor ORG (#58408)
9d9abf2 
Currently you pass in the ORG and it still tries to publish to Angular rather than your ow ORG repo that gets created

PR Close #58408
thePunderWoman pushed a commit that referenced this pull request Nov 1, 2024
@Jordan-Hall @thePunderWoman
build: Update publish-build-artifacts to honor ORG (#58408)
257d5b9 
Currently you pass in the ORG and it still tries to publish to Angular rather than your ow ORG repo that gets created

PR Close #58408
@thePunderWoman
Copy link
Contributor

thePunderWoman commented Nov 1, 2024

This PR was merged into the repository by commit 45adc72.

The changes were merged into the following branches: main, 18.2.x, 19.0.x

@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Dec 2, 2024

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@devversion devversion devversion approved these changes

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project area: devtools target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

Backlog

Development

Successfully merging this pull request may close these issues.

3 participants

@Jordan-Hall @thePunderWoman @devversion