Skip to content

Conversation

@looshch
Copy link
Contributor

@looshch looshch commented Oct 27, 2024

Fix backtick escaping for the template string example in the documentation on expression syntax.

Closes #58382

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.dev application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

there is an incorrect backtick escaping in the section about unsupported literals the documentation on expression syntax (highlighted on the first screenshot and without highlighting on the second one)

Image
Image

Issue Number: #58382

What is the new behavior?

the syntax is highlighted correctly

highlighted with a cursor
Screenshot 2024-10-27 at 7 13 30 PM

without cursor highlighting
Screenshot 2024-10-27 at 7 13 14 PM

Does this PR introduce a breaking change?

  • Yes
  • No

@pullapprove pullapprove bot requested a review from bencodezen October 27, 2024 19:10
@angular-robot angular-robot bot added the area: docs Related to the documentation label Oct 27, 2024
@ngbot ngbot bot added this to the Backlog milestone Oct 27, 2024
Fix backtick escaping for the template string example in the
documentation on expression syntax.

Closes #58382

PR Close #58383
@github-actions
Copy link

Deployed adev-preview for d537e14 to: https://ng-dev-previews-fw--pr-angular-angular-58383-adev-prev-eya7iiq5.web.app

Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt.

Copy link
Member

@JeanMeche JeanMeche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this !

@JeanMeche JeanMeche removed the request for review from bencodezen October 27, 2024 19:54
@JeanMeche JeanMeche added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Oct 27, 2024
@looshch looshch closed this by deleting the head repository Oct 28, 2024
@JeanMeche
Copy link
Member

@looshch Looks like you deleted the head repository hence closing the PR.

@looshch
Copy link
Contributor Author

looshch commented Oct 28, 2024

@JeanMeche oops late night mistakes, i thought i saw a mention that the both mine PRs were merged 🤦🏼‍♂️. Sorry for this, here’s re-opened PR with everything being the same

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker adev: preview area: docs Related to the documentation target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

incorrect backtick escaping in the documentation on expression syntax

2 participants