Skip to content

refactor(router): drop special handling of the OutletInjector#58351

Closed
AndrewKushnir wants to merge 1 commit intoangular:mainfrom
AndrewKushnir:outler_injector_cleanup
Closed

refactor(router): drop special handling of the OutletInjector#58351
AndrewKushnir wants to merge 1 commit intoangular:mainfrom
AndrewKushnir:outler_injector_cleanup

Conversation

@AndrewKushnir
Copy link
Copy Markdown
Contributor

This commit updates the OutletInjector and related code to avoid special handling of that injector. The main code that had special handling was refactored to no longer require is in #56763, this commit completes the cleanup.

PR Type

What kind of change does this PR introduce?

  • Refactoring (no functional changes, no api changes)

Does this PR introduce a breaking change?

  • Yes
  • No

@AndrewKushnir AndrewKushnir added action: review The PR is still awaiting reviews from at least one requested reviewer area: router target: rc This PR is targeted for the next release-candidate labels Oct 24, 2024
@ngbot ngbot bot added this to the Backlog milestone Oct 24, 2024
@AndrewKushnir AndrewKushnir requested a review from alxhub October 25, 2024 01:33
@AndrewKushnir AndrewKushnir force-pushed the outler_injector_cleanup branch from 8cddc28 to 701d129 Compare November 25, 2024 06:05
@AndrewKushnir AndrewKushnir added target: patch This PR is targeted for the next patch release and removed target: rc This PR is targeted for the next release-candidate labels Nov 25, 2024
@AndrewKushnir AndrewKushnir requested review from atscott and removed request for alxhub March 31, 2025 18:39
This commit updates the OutletInjector and related code to avoid special handling of that injector. The main code that had special handling was refactored to no longer require is in angular#56763, this commit completes the cleanup.
@AndrewKushnir AndrewKushnir force-pushed the outler_injector_cleanup branch from 701d129 to ba7c9e3 Compare March 31, 2025 19:16
@AndrewKushnir AndrewKushnir added action: presubmit The PR is in need of a google3 presubmit and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Mar 31, 2025
@AndrewKushnir
Copy link
Copy Markdown
Contributor Author

Presubmit.

@AndrewKushnir AndrewKushnir added action: merge The PR is ready for merge by the caretaker and removed action: presubmit The PR is in need of a google3 presubmit labels Mar 31, 2025
thePunderWoman pushed a commit that referenced this pull request Mar 31, 2025
This commit updates the OutletInjector and related code to avoid special handling of that injector. The main code that had special handling was refactored to no longer require is in #56763, this commit completes the cleanup.

PR Close #58351
@thePunderWoman
Copy link
Copy Markdown
Contributor

This PR was merged into the repository by commit 1fed7dc.

The changes were merged into the following branches: main, 19.2.x

@angular-automatic-lock-bot
Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators May 1, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker area: router target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants