Skip to content

refactor(compiler-cli): Prepare the compiler to flip the default standalone value. #58175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
JeanMeche wants to merge 1 commit into from
Closed

refactor(compiler-cli): Prepare the compiler to flip the default standalone value. #58175

JeanMeche wants to merge 1 commit into from

Conversation

@JeanMeche
Copy link
Member

@JeanMeche JeanMeche commented Oct 12, 2024 •
edited
Loading

On top of #58160

This is mainly a refactor to prepare the repo to flip the change and ease the landing into G3.

@angular-robot angular-robot bot added area: build & ci Related the build and CI infrastructure of the project area: core Issues related to the framework runtime area: docs-infra Angular.dev application and infrastructure area: devtools area: language-service Issues related to Angular's VS Code language service labels Oct 12, 2024
@ngbot ngbot bot added this to the Backlog milestone Oct 12, 2024
@JeanMeche JeanMeche mentioned this pull request Oct 12, 2024
Closed
@JeanMeche JeanMeche force-pushed the feat/standalone-compiler-config branch from d93da1b to 884aabc Compare October 12, 2024 01:30
@angular-robot angular-robot bot added area: core Issues related to the framework runtime and removed area: core Issues related to the framework runtime labels Oct 12, 2024
@JeanMeche JeanMeche force-pushed the feat/standalone-compiler-config branch from 884aabc to 07f7ed5 Compare October 12, 2024 01:46
@angular-robot angular-robot bot added area: core Issues related to the framework runtime and removed area: core Issues related to the framework runtime labels Oct 12, 2024
@JeanMeche JeanMeche force-pushed the feat/standalone-compiler-config branch from 07f7ed5 to bb6cbd1 Compare October 12, 2024 10:23
@angular-robot angular-robot bot added area: core Issues related to the framework runtime and removed area: core Issues related to the framework runtime labels Oct 12, 2024
@JeanMeche JeanMeche force-pushed the feat/standalone-compiler-config branch from bb6cbd1 to 1dcb70e Compare October 12, 2024 10:25
@angular-robot angular-robot bot added area: core Issues related to the framework runtime and removed area: core Issues related to the framework runtime labels Oct 12, 2024
@JeanMeche JeanMeche force-pushed the feat/standalone-compiler-config branch from 1dcb70e to 89778bf Compare October 12, 2024 10:34
@angular-robot angular-robot bot added area: core Issues related to the framework runtime and removed area: core Issues related to the framework runtime labels Oct 12, 2024
@JeanMeche JeanMeche force-pushed the feat/standalone-compiler-config branch from 89778bf to 1d1047b Compare October 12, 2024 10:58
@angular-robot angular-robot bot added area: core Issues related to the framework runtime and removed area: core Issues related to the framework runtime labels Oct 12, 2024
@JeanMeche JeanMeche marked this pull request as ready for review October 12, 2024 21:41
@angular-robot angular-robot bot added area: core Issues related to the framework runtime and removed area: core Issues related to the framework runtime labels Oct 12, 2024
jelbourn
jelbourn approved these changes Oct 13, 2024
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pullapprove pullapprove bot requested a review from jelbourn October 13, 2024 01:18
@JeanMeche JeanMeche force-pushed the feat/standalone-compiler-config branch from 410c9ce to f033387 Compare October 14, 2024 15:05
@angular-robot angular-robot bot added area: core Issues related to the framework runtime and removed area: build & ci Related the build and CI infrastructure of the project area: core Issues related to the framework runtime labels Oct 14, 2024
@JeanMeche JeanMeche added area: build & ci Related the build and CI infrastructure of the project and removed state: blocked labels Oct 14, 2024
jelbourn
jelbourn approved these changes Oct 14, 2024
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Reviewed-for: global-approvers

@JeanMeche
refactor(core): Setup constant for standalone default value
a2dfee5 
This commit is part of the migration to standalone by default and sets up 2 files with a default value for standalone. They are still `false` in this case to land the change into G3 first. The switch to `true` will be executed in a follow-up PR.
@JeanMeche JeanMeche force-pushed the feat/standalone-compiler-config branch from f033387 to a2dfee5 Compare October 14, 2024 15:30
@angular-robot angular-robot bot added area: core Issues related to the framework runtime and removed area: build & ci Related the build and CI infrastructure of the project area: core Issues related to the framework runtime labels Oct 14, 2024
@JeanMeche JeanMeche added the target: major This PR is targeted for the next major release label Oct 14, 2024
@devversion devversion added the action: merge The PR is ready for merge by the caretaker label Oct 14, 2024
@devversion
Copy link
Member

devversion commented Oct 14, 2024

This PR was merged into the repository by commit 517da95.

The changes were merged into the following branches: main

@JeanMeche JeanMeche deleted the feat/standalone-compiler-config branch October 14, 2024 16:06
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Nov 14, 2024

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@JoostK JoostK JoostK left review comments

@jelbourn jelbourn jelbourn approved these changes

@alxhub alxhub alxhub approved these changes

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker area: core Issues related to the framework runtime area: devtools area: docs-infra Angular.dev application and infrastructure area: language-service Issues related to Angular's VS Code language service target: major This PR is targeted for the next major release

Projects

None yet

Milestone

Backlog

Development

Successfully merging this pull request may close these issues.

5 participants

@JeanMeche @devversion @JoostK @jelbourn @alxhub