Skip to content

refactor(core): standalone: false #58160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
JeanMeche wants to merge 8 commits into from
Closed

refactor(core): standalone: false #58160

JeanMeche wants to merge 8 commits into from

Conversation

@JeanMeche
Copy link
Member

@JeanMeche JeanMeche commented Oct 11, 2024 •
edited
Loading

1st step to migrate the repo to enable standalone by default: Prepare the codebase to recieve the change by setting standalone: false on NgModule declared components.

@angular-robot angular-robot bot added area: build & ci Related the build and CI infrastructure of the project area: core Issues related to the framework runtime area: docs-infra Angular.dev application and infrastructure area: devtools labels Oct 11, 2024
@ngbot ngbot bot added this to the Backlog milestone Oct 11, 2024
@angular-robot angular-robot bot added the area: language-service Issues related to Angular's VS Code language service label Oct 11, 2024
@JeanMeche JeanMeche changed the title refactor(core): standalone: false refactor(core): standalone: false Oct 11, 2024
@JeanMeche JeanMeche marked this pull request as draft October 11, 2024 10:38
@JeanMeche JeanMeche force-pushed the feat/standalone-explicit-false branch from ae2644c to 8ad32a9 Compare October 11, 2024 12:30
@angular-robot angular-robot bot added area: core Issues related to the framework runtime and removed area: core Issues related to the framework runtime labels Oct 11, 2024
@JeanMeche JeanMeche force-pushed the feat/standalone-explicit-false branch from 8ad32a9 to f4e77a4 Compare October 11, 2024 12:35
@angular-robot angular-robot bot added area: core Issues related to the framework runtime and removed area: core Issues related to the framework runtime labels Oct 11, 2024
@JeanMeche JeanMeche force-pushed the feat/standalone-explicit-false branch from f4e77a4 to a20849e Compare October 11, 2024 12:44
@angular-robot angular-robot bot added area: core Issues related to the framework runtime and removed area: core Issues related to the framework runtime labels Oct 11, 2024
@JeanMeche JeanMeche force-pushed the feat/standalone-explicit-false branch from a20849e to 596a31f Compare October 11, 2024 12:55
@angular-robot angular-robot bot added area: core Issues related to the framework runtime and removed area: core Issues related to the framework runtime labels Oct 11, 2024
@angular-robot angular-robot bot added the area: core Issues related to the framework runtime label Oct 12, 2024
jelbourn
jelbourn approved these changes Oct 13, 2024
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Reviewed-for: global-approvers

@jelbourn jelbourn added the action: merge The PR is ready for merge by the caretaker label Oct 13, 2024
@devversion
Copy link
Member

devversion commented Oct 14, 2024 •
edited
Loading

@JeanMeche @jelbourn is this really ready to merge? I see global approval, but many pending reviewers. Please remove those if ready (caretaker only merges PRs that are fully green w/ merge ready— OR if there is a caretaker note for pending/failing checks)

@devversion
Copy link
Member

devversion commented Oct 14, 2024

This PR was merged into the repository by commit c42759b.

The changes were merged into the following branches: main

devversion pushed a commit that referenced this pull request Oct 14, 2024
@JeanMeche @devversion
refactor(docs-infra): Migrate with schematic. (#58160)
7cd0e8d 
All components, directives and pipes will now use standalone as default. Non-standalone decorators have now .

PR Close #58160
devversion pushed a commit that referenced this pull request Oct 14, 2024
@JeanMeche @devversion
refactor(devtools): Migrate with the schematic. (#58160)
30766d6 
All components, directives and pipes will now use standalone as default. Non-standalone decorators have now .

PR Close #58160
devversion pushed a commit that referenced this pull request Oct 14, 2024
@JeanMeche @devversion
build: Migrate all integration tests with the schematic. (#58160)
e85021a 
All components, directives and pipes will now use standalone as default. Non-standalone decorators have now .

PR Close #58160
devversion pushed a commit that referenced this pull request Oct 14, 2024
@JeanMeche @devversion
refactor(core): Migrate modules directory with the schematic. (#58160)
afcc3ee 
All components, directives and pipes will now use standalone as default. Non-standalone decorators have now .

PR Close #58160
devversion pushed a commit that referenced this pull request Oct 14, 2024
@JeanMeche @devversion
refactor(compiler-cli): Migrate manually ngtsc tests to standalone by…
7aa3097 
… default (#58160)

This commit is part of the migration to standalone by default.

PR Close #58160
devversion pushed a commit that referenced this pull request Oct 14, 2024
@JeanMeche @devversion
refactor(language-service): Migrate manually ngtsc tests to standalon…
c7fac7e 
…e by default (#58160)

This commit is part of the migration to standalone by default.

PR Close #58160
devversion pushed a commit that referenced this pull request Oct 14, 2024
@JeanMeche @devversion
refactor(compiler-cli): Update compliance golden partials (#58160)
c42759b 
This commit is part of the update to standalone by default

PR Close #58160
@JeanMeche JeanMeche mentioned this pull request Oct 14, 2024
Closed
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Nov 14, 2024

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jelbourn jelbourn jelbourn approved these changes

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project area: core Issues related to the framework runtime area: devtools area: docs-infra Angular.dev application and infrastructure area: language-service Issues related to Angular's VS Code language service target: major This PR is targeted for the next major release

Projects

None yet

Milestone

Backlog

Development

Successfully merging this pull request may close these issues.

3 participants

@JeanMeche @devversion @jelbourn