Skip to content

refactor(core): drop ViewRefTracker in favor of ApplicationRef.#58096

Closed
JeanMeche wants to merge 1 commit intoangular:mainfrom
JeanMeche:core/ViewRefTracker
Closed

refactor(core): drop ViewRefTracker in favor of ApplicationRef.#58096
JeanMeche wants to merge 1 commit intoangular:mainfrom
JeanMeche:core/ViewRefTracker

Conversation

@JeanMeche
Copy link
Member

We can leverage an import type to prevent the circular import.

We can leverage an `import type` to prevent the circular import.
@angular-robot angular-robot bot added the area: core Issues related to the framework runtime label Oct 5, 2024
@ngbot ngbot bot added this to the Backlog milestone Oct 5, 2024
@JeanMeche JeanMeche marked this pull request as ready for review October 6, 2024 11:36
@pullapprove pullapprove bot requested a review from AndrewKushnir October 6, 2024 11:36
Copy link
Contributor

@AndrewKushnir AndrewKushnir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JeanMeche thanks for the cleanup!

@AndrewKushnir AndrewKushnir added action: presubmit The PR is in need of a google3 presubmit target: minor This PR is targeted for the next minor release target: patch This PR is targeted for the next patch release and removed target: minor This PR is targeted for the next minor release labels Oct 6, 2024
@AndrewKushnir
Copy link
Contributor

Presubmit.

@AndrewKushnir AndrewKushnir added action: merge The PR is ready for merge by the caretaker and removed action: presubmit The PR is in need of a google3 presubmit labels Oct 8, 2024
@AndrewKushnir
Copy link
Contributor

This PR was merged into the repository by commit 66c3980.

The changes were merged into the following branches: main, 18.2.x

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker area: core Issues related to the framework runtime target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants