Skip to content

Conversation

@nesjett
Copy link
Contributor

@nesjett nesjett commented Oct 3, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

This PR was previously closed because of inactivity. Let me know if this is not the right way of resending it, but otherwise, which commit message should I have set on the correction?

Original PR: #57437

@pullapprove pullapprove bot requested a review from AndrewKushnir October 3, 2024 20:42
@angular-robot angular-robot bot added area: docs Related to the documentation area: router labels Oct 3, 2024
@ngbot ngbot bot added this to the Backlog milestone Oct 3, 2024
Copy link
Contributor

@AndrewKushnir AndrewKushnir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nesjett thanks for improving Angular docs!

@AndrewKushnir AndrewKushnir added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note labels Oct 11, 2024
@AndrewKushnir
Copy link
Contributor

Caretaker note: no presubmit is required, docs-only change.

@devversion
Copy link
Member

Note: adding cleanup label. Lint seems to be failing.

@devversion devversion added action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews and removed action: merge The PR is ready for merge by the caretaker labels Oct 13, 2024
@nesjett
Copy link
Contributor Author

nesjett commented Oct 13, 2024

Do I need to do anything? The command that failed seem to modify the file but not changing anything at all. (maybe some EOF or something?)

yarn ng-dev format files packages/router/src/models.ts

I can update the PR with that change, but what commit message should I use, chore? It does not seem to fit any of the listed in the "contributing" docs: https://github.com/angular/angular/blob/main/CONTRIBUTING.md#commit

@devversion
Copy link
Member

Hmm. Maybe you are not rebased? CI runs with a rebased version

@JeanMeche
Copy link
Member

JeanMeche commented Oct 14, 2024

I the script ran on the branch of the PR, it updates and fixes the file without a rebase (by removing a trailing space).
Can you double check that you don't get any changes ?

@angular-robot angular-robot bot requested a review from AndrewKushnir October 18, 2024 20:31
@AndrewKushnir AndrewKushnir added action: merge The PR is ready for merge by the caretaker and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Oct 24, 2024
@AndrewKushnir
Copy link
Contributor

Caretaker note: no presubmit is required, docs-only change.

@alxhub
Copy link
Member

alxhub commented Oct 24, 2024

This PR was merged into the repository by commit 18ddf0d.

The changes were merged into the following branches: main, 18.2.x, 19.0.x

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker area: docs Related to the documentation area: router merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants