Skip to content

refactor(core): Remove global event delegation code.#57893

Closed
iteriani wants to merge 1 commit intoangular:mainfrom
iteriani:delete_global_event_delegation
Closed

refactor(core): Remove global event delegation code.#57893
iteriani wants to merge 1 commit intoangular:mainfrom
iteriani:delete_global_event_delegation

Conversation

@iteriani
Copy link
Contributor

@iteriani iteriani commented Sep 19, 2024

This is no longer needed since we are no longer experimenting with it.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Removes experimental global event delegation code.

Does this PR introduce a breaking change?

  • Yes
  • No

This code was only introduced for internal testing, so it won't be a breaking change.

Other information

@pullapprove pullapprove bot requested a review from alxhub September 19, 2024 23:17
@angular-robot angular-robot bot added the area: core Issues related to the framework runtime label Sep 19, 2024
@ngbot ngbot bot added this to the Backlog milestone Sep 19, 2024
@iteriani iteriani requested review from thePunderWoman and removed request for alxhub September 19, 2024 23:17
@iteriani iteriani force-pushed the delete_global_event_delegation branch from da33989 to 3c92980 Compare September 19, 2024 23:47
@angular-robot angular-robot bot added area: core Issues related to the framework runtime and removed area: core Issues related to the framework runtime labels Sep 19, 2024
@AndrewKushnir AndrewKushnir removed the request for review from thePunderWoman September 25, 2024 17:35
@AndrewKushnir
Copy link
Contributor

AndrewKushnir commented Sep 25, 2024

@iteriani could you please rebase this PR and resolve merge conflicts?

@AndrewKushnir AndrewKushnir added target: patch This PR is targeted for the next patch release action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Sep 25, 2024
@iteriani
refactor(core): Remove global event delegation code.
487142a 
This is no longer needed since we are no longer experimenting with it.
@iteriani iteriani force-pushed the delete_global_event_delegation branch from 3c92980 to 487142a Compare September 25, 2024 17:41
@angular-robot angular-robot bot added area: core Issues related to the framework runtime and removed area: core Issues related to the framework runtime labels Sep 25, 2024
@AndrewKushnir AndrewKushnir added action: presubmit The PR is in need of a google3 presubmit and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Sep 25, 2024
@AndrewKushnir
Copy link
Contributor

AndrewKushnir commented Sep 25, 2024

Presubmit.

@iteriani iteriani added the action: merge The PR is ready for merge by the caretaker label Sep 25, 2024
@AndrewKushnir AndrewKushnir removed the action: presubmit The PR is in need of a google3 presubmit label Sep 25, 2024
@alxhub
Copy link
Member

alxhub commented Sep 26, 2024

This PR was merged into the repository by commit 5f356fc.

The changes were merged into the following branches: main, 18.2.x

@alxhub alxhub closed this in 5f356fc Sep 26, 2024
alxhub pushed a commit that referenced this pull request Sep 26, 2024
@iteriani @alxhub
refactor(core): Remove global event delegation code. (#57893)
2e7cfcb 
This is no longer needed since we are no longer experimenting with it.

PR Close #57893
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Oct 27, 2024

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@AndrewKushnir AndrewKushnir AndrewKushnir approved these changes

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker area: core Issues related to the framework runtime target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

Backlog

Development

Successfully merging this pull request may close these issues.

3 participants

@iteriani @AndrewKushnir @alxhub