Skip to content

docs(core): update wording in ComponentDecorator#57878

Closed
ChinoUkaegbu wants to merge 1 commit intoangular:mainfrom
ChinoUkaegbu:docs/fix-component-decorator-wording-2
Closed

docs(core): update wording in ComponentDecorator#57878
ChinoUkaegbu wants to merge 1 commit intoangular:mainfrom
ChinoUkaegbu:docs/fix-component-decorator-wording-2

Conversation

@ChinoUkaegbu
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

The documentation insists that a component must belong to an NgModule in order for it to be available to another component or application.

Issue Number: #57689

What is the new behavior?

The documentation still provides instructions to make a component a member of an NgModule, but only when running Angular with NgModule

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Replacement for #57709

@pullapprove pullapprove bot requested a review from dylhunn September 19, 2024 14:41
@angular-robot angular-robot bot added area: docs Related to the documentation area: core Issues related to the framework runtime labels Sep 19, 2024
@ngbot ngbot bot added this to the Backlog milestone Sep 19, 2024
@JeanMeche JeanMeche requested review from bencodezen and removed request for dylhunn September 19, 2024 15:17
@pullapprove pullapprove bot requested a review from dylhunn September 19, 2024 15:17
Copy link
Contributor

@bencodezen bencodezen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@bencodezen bencodezen added target: patch This PR is targeted for the next patch release action: merge The PR is ready for merge by the caretaker labels Sep 19, 2024
@pkozlowski-opensource pkozlowski-opensource removed the request for review from dylhunn September 23, 2024 09:45
@pullapprove pullapprove bot requested a review from dylhunn September 23, 2024 09:46
@pkozlowski-opensource pkozlowski-opensource added the merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note label Sep 23, 2024
@pkozlowski-opensource
Copy link
Member

caretaker note: docs-only change, no presubmit required

@pkozlowski-opensource pkozlowski-opensource removed the request for review from dylhunn September 23, 2024 09:58
@pkozlowski-opensource
Copy link
Member

This PR was merged into the repository by commit d30cef2.

The changes were merged into the following branches: main, 18.2.x

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker area: core Issues related to the framework runtime area: docs Related to the documentation merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants