Skip to content

docs: correct key usage in sectionStyles and update template binding #57820

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
sammychinedu2ky wants to merge 1 commit into from
Closed

docs: correct key usage in sectionStyles and update template binding #57820

sammychinedu2ky wants to merge 1 commit into from

Conversation

@sammychinedu2ky
Copy link
Contributor

@sammychinedu2ky sammychinedu2ky commented Sep 15, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • [✅] Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

This PR fixes an issue related to object key formatting in sectionStyles and updates the template binding in the

element to apply dynamic styles correctly.

@pullapprove pullapprove bot requested a review from crisbeto September 15, 2024 21:12
@angular-robot angular-robot bot added the area: docs Related to the documentation label Sep 15, 2024
@ngbot ngbot bot added this to the Backlog milestone Sep 15, 2024
JeanMeche
JeanMeche approved these changes Sep 16, 2024
View reviewed changes
Copy link
Member

@JeanMeche JeanMeche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this

@JeanMeche JeanMeche removed the request for review from crisbeto September 16, 2024 06:32
@JeanMeche JeanMeche added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Sep 16, 2024
@sammychinedu2ky
Copy link
Contributor Author

sammychinedu2ky commented Sep 16, 2024

Thanks for this

my pleasure 🚀

@pkozlowski-opensource
Copy link
Member

pkozlowski-opensource commented Sep 16, 2024

This PR was merged into the repository by commit b0d68b2.

The changes were merged into the following branches: main, 18.2.x

pkozlowski-opensource pushed a commit that referenced this pull request Sep 16, 2024
@sammychinedu2ky @pkozlowski-opensource
docs: correct key usage in sectionStyles and update template binding (#…
e16b8a3 
…57820)

PR Close #57820
@pkozlowski-opensource pkozlowski-opensource mentioned this pull request Sep 23, 2024
Closed
14 tasks
This was referenced Oct 12, 2024
Open
Open
Open
Open
Open
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Oct 17, 2024

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@JeanMeche JeanMeche JeanMeche approved these changes

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker area: docs Related to the documentation target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

Backlog

Development

Successfully merging this pull request may close these issues.

3 participants

@sammychinedu2ky @pkozlowski-opensource @JeanMeche