Skip to content

docs: fix example for defer on hover on an alternative element #57788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
pweyrich wants to merge 1 commit into from
Closed

docs: fix example for defer on hover on an alternative element #57788

pweyrich wants to merge 1 commit into from

Conversation

@pweyrich
Copy link
Contributor

@pweyrich pweyrich commented Sep 12, 2024 •
edited
Loading

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@pullapprove pullapprove bot requested a review from bencodezen September 12, 2024 07:45
@angular-robot angular-robot bot added area: docs Related to the documentation area: adev labels Sep 12, 2024
@ngbot ngbot bot added this to the Backlog milestone Sep 12, 2024
JeanMeche
JeanMeche approved these changes Sep 12, 2024
View reviewed changes
Copy link
Member

@JeanMeche JeanMeche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this !

@JeanMeche JeanMeche added action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews target: patch This PR is targeted for the next patch release labels Sep 12, 2024
@JeanMeche
Copy link
Member

JeanMeche commented Sep 12, 2024

Could you please drop the scope from your commit message (adev isn't a valid one) and make it a docs: ..., thank you.

@pweyrich pweyrich changed the title docs(adev): fix example for defer on hover on an alternative element docs: fix example for defer on hover on an alternative element Sep 12, 2024
@pweyrich
Copy link
Contributor Author

pweyrich commented Sep 12, 2024

Could you please drop the scope from your commit message (adev isn't a valid one) and make it a docs: ..., thank you.

Done

@JeanMeche JeanMeche added action: merge The PR is ready for merge by the caretaker and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Sep 12, 2024
@pkozlowski-opensource pkozlowski-opensource removed the request for review from bencodezen September 12, 2024 09:18
@pkozlowski-opensource
Copy link
Member

pkozlowski-opensource commented Sep 12, 2024

This PR was merged into the repository by commit 55e3a3a.

The changes were merged into the following branches: main, 18.2.x

pkozlowski-opensource pushed a commit that referenced this pull request Sep 12, 2024
@pweyrich @pkozlowski-opensource
docs: fix example for defer on hover on an alternative element (#57788)
156f0d0 
PR Close #57788
@pweyrich pweyrich deleted the patch-1 branch September 12, 2024 09:37
This was referenced Oct 12, 2024
Open
Open
Open
Open
Open
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Oct 13, 2024

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@JeanMeche JeanMeche JeanMeche approved these changes

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker area: docs Related to the documentation target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

Backlog

Development

Successfully merging this pull request may close these issues.

3 participants

@pweyrich @JeanMeche @pkozlowski-opensource