Skip to content

Conversation

@P4
Copy link
Contributor

@P4 P4 commented Sep 11, 2024

https://angular.dev/extended-diagnostics/NG8106#configuration-requirements

"Configuration requirements" referred to the wrong diagnostic (invalidBananaInBox) likely due to a copy-paste error

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Documentation for suffixNotSupported talks about invalidBananaInBox.

What is the new behavior?

Documentation for suffixNotSupported talks about suffixNotSupported, follows the same formula as most other diagnostics.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

"Configuration requirements" referred to the wrong diagnostic (`invalidBananaInBox`)
likely due to a copy-paste error
@pullapprove pullapprove bot requested a review from atscott September 11, 2024 11:27
@angular-robot angular-robot bot added the area: docs Related to the documentation label Sep 11, 2024
@ngbot ngbot bot added this to the Backlog milestone Sep 11, 2024
@bencodezen bencodezen added the action: review The PR is still awaiting reviews from at least one requested reviewer label Sep 11, 2024
Copy link
Contributor

@AndrewKushnir AndrewKushnir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for improving the docs!

@AndrewKushnir AndrewKushnir added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Sep 14, 2024
@AndrewKushnir AndrewKushnir removed the request for review from atscott September 14, 2024 16:54
@pkozlowski-opensource
Copy link
Member

This PR was merged into the repository by commit 716f0d5.

The changes were merged into the following branches: main, 18.2.x

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker area: docs Related to the documentation target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants