Skip to content

Conversation

@Skn0tt
Copy link
Contributor

@Skn0tt Skn0tt commented Sep 9, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

E2E docs don't list Playwright.

What is the new behavior?

Added Playwright to the list of e2e testing tools.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Goes hand in hand with angular/angular-cli#28377. Just like in that PR, I'm happy to change the ordering of tools if you think Playwright should be in a different position in the list.

@pullapprove pullapprove bot requested a review from jelbourn September 9, 2024 11:56
@angular-robot angular-robot bot added the area: docs Related to the documentation label Sep 9, 2024
@ngbot ngbot bot added this to the Backlog milestone Sep 9, 2024
@Skn0tt
Copy link
Contributor Author

Skn0tt commented Sep 9, 2024

Alan mentioned in angular/angular-cli#28377 (comment) that the list should be alphabetised, gonna do that.

Copy link
Contributor

@alan-agius4 alan-agius4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you squash the commits and remove the type (@angular/cli) from the commit?

Thanks

@alan-agius4 alan-agius4 added action: review The PR is still awaiting reviews from at least one requested reviewer target: patch This PR is targeted for the next patch release labels Sep 9, 2024
docs: alphabetisize list
@Skn0tt Skn0tt force-pushed the e2e-add-playwright branch from 71bbd2a to f88f652 Compare September 9, 2024 12:01
Copy link
Contributor

@alan-agius4 alan-agius4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Sep 11, 2024
@alan-agius4
Copy link
Contributor

Caretaker note: my approval should suffice

@thePunderWoman thePunderWoman removed the request for review from jelbourn September 11, 2024 21:23
@thePunderWoman thePunderWoman removed the merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note label Sep 11, 2024
thePunderWoman pushed a commit that referenced this pull request Sep 11, 2024
docs: alphabetisize list

PR Close #57734
@thePunderWoman
Copy link
Contributor

This PR was merged into the repository by commit ba386c7.

The changes were merged into the following branches: main, 18.2.x

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker area: docs Related to the documentation target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants