-
Notifications
You must be signed in to change notification settings - Fork 27k
docs(@angular/cli): add Playwright to E2E tools #57734
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Alan mentioned in angular/angular-cli#28377 (comment) that the list should be alphabetised, gonna do that. |
alan-agius4
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you squash the commits and remove the type (@angular/cli) from the commit?
Thanks
docs: alphabetisize list
71bbd2a to
f88f652
Compare
alan-agius4
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
Caretaker note: my approval should suffice |
docs: alphabetisize list PR Close #57734
|
This PR was merged into the repository by commit ba386c7. The changes were merged into the following branches: main, 18.2.x |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
E2E docs don't list Playwright.
What is the new behavior?
Added Playwright to the list of e2e testing tools.
Does this PR introduce a breaking change?
Other information
Goes hand in hand with angular/angular-cli#28377. Just like in that PR, I'm happy to change the ordering of tools if you think Playwright should be in a different position in the list.