refactor(compiler-cli): Do not extract symbols from private modules.#57611
Closed
JeanMeche wants to merge 1 commit intoangular:mainfrom
Closed
refactor(compiler-cli): Do not extract symbols from private modules.#57611JeanMeche wants to merge 1 commit intoangular:mainfrom
JeanMeche wants to merge 1 commit intoangular:mainfrom
Conversation
9e4fb18 to
a056be8
Compare
|
Deployed adev-preview for 70ea93d to: https://ng-dev-previews-fw--pr-angular-angular-57611-adev-prev-7o05yl25.web.app Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt. |
47f1363 to
1b52f63
Compare
devversion
approved these changes
Aug 31, 2024
adev/shared-docs/pipeline/api-gen/extraction/extract_api_to_json.bzl
Outdated
Show resolved
Hide resolved
Modules like `core/primitives` are considered private and their symbols shouldn't be exposed nor linked in the docs.
1b52f63 to
70ea93d
Compare
devversion
approved these changes
Sep 4, 2024
thePunderWoman
pushed a commit
that referenced
this pull request
Sep 6, 2024
) Modules like `core/primitives` are considered private and their symbols shouldn't be exposed nor linked in the docs. PR Close #57611
Contributor
|
This PR was merged into the repository by commit 1698bd3. The changes were merged into the following branches: main, 18.2.x |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up for #57346
Modules like
core/primitivesare considered private and their symbols shouldn't be exposed nor linked in the docs.