Skip to content

Conversation

@JsantosDK
Copy link
Contributor

@JsantosDK JsantosDK commented Aug 28, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Fixes #54390

@pullapprove pullapprove bot requested a review from crisbeto August 28, 2024 18:13
@angular-robot angular-robot bot added the area: docs Related to the documentation label Aug 28, 2024
@ngbot ngbot bot added this to the Backlog milestone Aug 28, 2024
@JsantosDK JsantosDK force-pushed the docs/add-interceptor-testing branch from 9db8b82 to 2cef101 Compare August 28, 2024 18:15
Copy link
Member

@JeanMeche JeanMeche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More generaly I think this guide should illustrate testing a HttpInterceptorFn since this is the recommended implementation for Interceptors.

@JsantosDK
Copy link
Contributor Author

More generaly I think this guide should illustrate testing a HttpInterceptorFn since this is the recommended implementation for Interceptors.

In general, I agree with this, hence why I added the example for the functional interceptor first.

However, I was not sure how to proceed in this case, given that Angular still supports interceptors from DI.
Because of this, not having any details on how to test these interceptors seems a bit wrong, hence why I added them.

Let me know if these should be removed, or changed in some way.

@JsantosDK JsantosDK force-pushed the docs/add-interceptor-testing branch from 2cef101 to f3bf3da Compare September 21, 2024 11:35
@JsantosDK JsantosDK requested a review from JeanMeche September 24, 2024 19:31
@JsantosDK JsantosDK requested a review from JeanMeche October 5, 2024 18:20
@JsantosDK JsantosDK force-pushed the docs/add-interceptor-testing branch from f3bf3da to f089f42 Compare October 10, 2024 18:10
@JsantosDK
Copy link
Contributor Author

@JeanMeche any word on this?
Is there anything blocking it?

Copy link
Member

@JeanMeche JeanMeche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, at least it a good start on that topic

@JeanMeche JeanMeche removed the request for review from crisbeto November 10, 2024 23:03
@JeanMeche
Copy link
Member

We'll need you to drop that merge commit, the change needs to be a single commit to be merged.

1 similar comment
@JeanMeche
Copy link
Member

We'll need you to drop that merge commit, the change needs to be a single commit to be merged.

@JsantosDK
Copy link
Contributor Author

JsantosDK commented Nov 11, 2024

@JeanMeche I had to force push to remove the unwanted commit. Could you please re-add the labels and merge?

@JsantosDK JsantosDK force-pushed the docs/add-interceptor-testing branch from 892b2aa to d01d742 Compare November 11, 2024 12:40
@angular-robot angular-robot bot added the detected: breaking change PR contains a commit with a breaking change label Nov 11, 2024
@angular-robot angular-robot bot added area: docs-infra Angular.dev application and infrastructure area: common Issues related to APIs in the @angular/common package area: forms area: service-worker Issues related to the @angular/service-worker package area: router area: devtools labels Nov 11, 2024
@JsantosDK JsantosDK force-pushed the docs/add-interceptor-testing branch from d01d742 to bc2baba Compare November 11, 2024 12:45
@pullapprove pullapprove bot removed the requires: TGP This PR requires a passing TGP before merging is allowed label Nov 11, 2024
@angular-robot angular-robot bot removed area: compiler Issues related to `ngc`, Angular's template compiler area: core Issues related to the framework runtime labels Nov 11, 2024
@josephperrott josephperrott removed their request for review November 12, 2024 15:38
@JsantosDK
Copy link
Contributor Author

@JeanMeche is there anything pending on my part, or is it just tag updating and merging?

@JeanMeche JeanMeche added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Nov 13, 2024
thePunderWoman pushed a commit that referenced this pull request Nov 14, 2024
thePunderWoman pushed a commit that referenced this pull request Nov 14, 2024
@thePunderWoman
Copy link
Contributor

This PR was merged into the repository by commit 6674130.

The changes were merged into the following branches: main, 18.2.x, 19.0.x

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker area: common Issues related to APIs in the @angular/common package area: devtools area: docs Related to the documentation area: docs-infra Angular.dev application and infrastructure area: forms area: language-service Issues related to Angular's VS Code language service area: migrations Issues related to `ng update`/`ng generate` migrations area: router area: service-worker Issues related to the @angular/service-worker package area: upgrade Issues related to AngularJS → Angular upgrade APIs target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

angular.dev: no documentation on how to test interceptors

3 participants