-
Notifications
You must be signed in to change notification settings - Fork 27k
docs: adds interceptor testing #57568
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
9db8b82 to
2cef101
Compare
JeanMeche
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
More generaly I think this guide should illustrate testing a HttpInterceptorFn since this is the recommended implementation for Interceptors.
In general, I agree with this, hence why I added the example for the functional interceptor first. However, I was not sure how to proceed in this case, given that Angular still supports interceptors from DI. Let me know if these should be removed, or changed in some way. |
2cef101 to
f3bf3da
Compare
f3bf3da to
f089f42
Compare
|
@JeanMeche any word on this? |
JeanMeche
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, at least it a good start on that topic
|
We'll need you to drop that merge commit, the change needs to be a single commit to be merged. |
1 similar comment
|
We'll need you to drop that merge commit, the change needs to be a single commit to be merged. |
|
@JeanMeche I had to force push to remove the unwanted commit. Could you please re-add the labels and merge? |
892b2aa to
d01d742
Compare
d01d742 to
bc2baba
Compare
|
@JeanMeche is there anything pending on my part, or is it just tag updating and merging? |
|
This PR was merged into the repository by commit 6674130. The changes were merged into the following branches: main, 18.2.x, 19.0.x |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information
Fixes #54390