Skip to content

refactor(migrations): allow tsurge migrations to run with just NgCompiler #57562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
devversion wants to merge 1 commit into from
Closed

refactor(migrations): allow tsurge migrations to run with just NgCompiler #57562

devversion wants to merge 1 commit into from

Conversation

@devversion
Copy link
Member

@devversion devversion commented Aug 28, 2024

This is important so that migrations can easily be wired up in the language service where
only NgCompiler is available.

@devversion
refactor(migrations): allow tsurge migrations to run with just `NgCom…
4eeb0ff 
…piler`

This is important so that migrations can easily be wired up in the
language service where only `NgCompiler` is available.
@devversion devversion added action: review The PR is still awaiting reviews from at least one requested reviewer target: patch This PR is targeted for the next patch release labels Aug 28, 2024
@devversion devversion requested a review from crisbeto August 28, 2024 11:52
@angular-robot angular-robot bot added the area: migrations Issues related to `ng update`/`ng generate` migrations label Aug 28, 2024
@ngbot ngbot bot added this to the Backlog milestone Aug 28, 2024
@devversion devversion added merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Aug 28, 2024
@devversion
Copy link
Member Author

devversion commented Aug 28, 2024

Caretaker note: Please patch https://critique.corp.google.com/cl/668403250 into your sync.

@devversion devversion added the action: merge The PR is ready for merge by the caretaker label Aug 28, 2024
@devversion devversion mentioned this pull request Aug 28, 2024
Closed
@alxhub
Copy link
Member

alxhub commented Aug 28, 2024

This PR was merged into the repository by commit 29e526c.

The changes were merged into the following branches: main, 18.2.x

alxhub pushed a commit that referenced this pull request Aug 28, 2024
@devversion @alxhub
refactor(migrations): allow tsurge migrations to run with just `NgCom…
389933f 
…piler` (#57562)

This is important so that migrations can easily be wired up in the
language service where only `NgCompiler` is available.

PR Close #57562
@alxhub alxhub closed this in 29e526c Aug 28, 2024
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Sep 28, 2024

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@crisbeto crisbeto crisbeto approved these changes

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker area: migrations Issues related to `ng update`/`ng generate` migrations merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

Backlog

Development

Successfully merging this pull request may close these issues.

3 participants

@devversion @alxhub @crisbeto