fix(core): avoid leaking memory if component throws during creation #57546
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
83742a6 to
b41f0d2
Compare
When we create the LView for a component, we track it in the `TRACKED_LVIEWS` map. It gets untracked when it is destroy, but if it throws during creation, the user won't have access to a `ComponentRef` in order to clean it up. These changes automatically untrack the related LViews if the component couldn't be created.
We had some tests that were leaking LViews, because we were testing things like `createComponent`, but not destroying them afterwards. These changes clean up most of them, although there are a handful still left that I didn't have time to fully track down.
b41f0d2 to
05c82d9
Compare
Member
Author
|
Feedback has been addressed. |
pkozlowski-opensource
approved these changes
Aug 27, 2024
Member
|
This PR was merged into the repository by commit 96b698c. The changes were merged into the following branches: main, 18.2.x |
alxhub
pushed a commit
that referenced
this pull request
Aug 27, 2024
…57546) When we create the LView for a component, we track it in the `TRACKED_LVIEWS` map. It gets untracked when it is destroy, but if it throws during creation, the user won't have access to a `ComponentRef` in order to clean it up. These changes automatically untrack the related LViews if the component couldn't be created. PR Close #57546
alxhub
pushed a commit
that referenced
this pull request
Aug 27, 2024
We had some tests that were leaking LViews, because we were testing things like `createComponent`, but not destroying them afterwards. These changes clean up most of them, although there are a handful still left that I didn't have time to fully track down. PR Close #57546
alxhub
pushed a commit
that referenced
this pull request
Aug 27, 2024
We had some tests that were leaking LViews, because we were testing things like `createComponent`, but not destroying them afterwards. These changes clean up most of them, although there are a handful still left that I didn't have time to fully track down. PR Close #57546
This was referenced Sep 15, 2024
This was referenced Sep 23, 2024
This was referenced Sep 24, 2024
This was referenced Sep 24, 2024
This was referenced Sep 24, 2024
Open
This was referenced Sep 25, 2024
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we create the LView for a component, we track it in the
TRACKED_LVIEWSmap. It gets untracked when it is destroy, but if it throws during creation, the user won't have access to aComponentRefin order to clean it up.These changes automatically untrack the related LViews if the component couldn't be created.
There's a second commit that fixes up some leaks in our own tests that I found while debugging.