Skip to content

build: remove Sourcemaps from Schematics bundles#57545

Closed
alan-agius4 wants to merge 3 commits intoangular:mainfrom
alan-agius4:sm-schematics
Closed

build: remove Sourcemaps from Schematics bundles#57545
alan-agius4 wants to merge 3 commits intoangular:mainfrom
alan-agius4:sm-schematics

Conversation

@alan-agius4
Copy link
Contributor

This commit reduces the bundle size of @angular/core by 19.5 MB by excluding sourcemaps from the schematics.

Since the esbuild rule doesn't allow disabling sourcemaps directly, we work around this by setting the sourcemaps to external. Afterward, we filter the output to include only the .js files.

@angular-robot angular-robot bot added the area: build & ci Related the build and CI infrastructure of the project label Aug 27, 2024
@ngbot ngbot bot added this to the Backlog milestone Aug 27, 2024
@alan-agius4 alan-agius4 added action: review The PR is still awaiting reviews from at least one requested reviewer target: patch This PR is targeted for the next patch release labels Aug 27, 2024
@alan-agius4 alan-agius4 marked this pull request as ready for review August 27, 2024 09:23
@alan-agius4 alan-agius4 added the area: migrations Issues related to `ng update`/`ng generate` migrations label Aug 27, 2024
@alan-agius4 alan-agius4 removed the request for review from AndrewKushnir August 27, 2024 09:42
@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Aug 27, 2024
This commit reduces the bundle size of `@angular/core` by 19.5 MB by excluding sourcemaps from the schematics.

Since the `esbuild` rule doesn't allow disabling sourcemaps directly, we work around this by setting the sourcemaps to `external`. Afterward, we filter the output to include only the `.js` files.
@alxhub
Copy link
Member

alxhub commented Aug 27, 2024

This PR was merged into the repository by commit 099955b.

The changes were merged into the following branches: main, 18.2.x

alxhub pushed a commit that referenced this pull request Aug 27, 2024
This commit reduces the bundle size of `@angular/core` by 19.5 MB by excluding sourcemaps from the schematics.

Since the `esbuild` rule doesn't allow disabling sourcemaps directly, we work around this by setting the sourcemaps to `external`. Afterward, we filter the output to include only the `.js` files.

PR Close #57545
@alxhub alxhub closed this in 099955b Aug 27, 2024
@alan-agius4 alan-agius4 deleted the sm-schematics branch August 27, 2024 20:42
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project area: migrations Issues related to `ng update`/`ng generate` migrations target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants