Skip to content

docs: adapt the NgModule to the new default : standalone #57532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
JeanMeche wants to merge 1 commit into from
Closed

docs: adapt the NgModule to the new default : standalone #57532

JeanMeche wants to merge 1 commit into from

Conversation

@JeanMeche
Copy link
Member

@JeanMeche JeanMeche commented Aug 26, 2024

No description provided.

@JeanMeche JeanMeche requested a review from bencodezen August 26, 2024 20:28
@angular-robot angular-robot bot added the area: docs Related to the documentation label Aug 26, 2024
@ngbot ngbot bot added this to the Backlog milestone Aug 26, 2024
@marcosebsilva
Copy link

marcosebsilva commented Aug 26, 2024 •
edited
Loading

Marcos from discord here.

I saw the same problem on different pages other than the ones that where changed on the PR. Is there a problem if a make some commits in your fork? Not sure how to reference those pages using github review tool, since they were not changed

bencodezen
bencodezen approved these changes Aug 27, 2024
View reviewed changes
Copy link
Contributor

@bencodezen bencodezen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. Looks good to me!

@bencodezen bencodezen added action: merge The PR is ready for merge by the caretaker target: minor This PR is targeted for the next minor release target: patch This PR is targeted for the next patch release and removed target: minor This PR is targeted for the next minor release labels Aug 27, 2024
@JeanMeche JeanMeche removed the action: merge The PR is ready for merge by the caretaker label Aug 27, 2024
@JeanMeche
Copy link
Member Author

JeanMeche commented Aug 27, 2024

I'll add some additional changes before we merge it !

@JeanMeche JeanMeche force-pushed the docs/module-standalone branch from b5578bd to 1ad7ee0 Compare September 6, 2024 12:56
@JeanMeche
Copy link
Member Author

JeanMeche commented Sep 6, 2024 •
edited
Loading

@bencodezen I've added a new set of changes, feel free to have a look !
Thanks for the help @marcosebsilva on this !

@JeanMeche JeanMeche force-pushed the docs/module-standalone branch from 1ad7ee0 to 2cf9083 Compare September 7, 2024 21:41
@JeanMeche JeanMeche force-pushed the docs/module-standalone branch from 2cf9083 to 833bad9 Compare September 7, 2024 21:43
@JeanMeche JeanMeche added the action: merge The PR is ready for merge by the caretaker label Sep 18, 2024
@pkozlowski-opensource
Copy link
Member

pkozlowski-opensource commented Sep 18, 2024

This PR was merged into the repository by commit 029163c.

The changes were merged into the following branches: main, 18.2.x

pkozlowski-opensource pushed a commit that referenced this pull request Sep 18, 2024
@JeanMeche @pkozlowski-opensource
docs: adapt the NgModule to the new default : standalone (#57532)
0365f38 
PR Close #57532
@JeanMeche JeanMeche deleted the docs/module-standalone branch September 18, 2024 14:54
This was referenced Oct 12, 2024
Open
Open
Open
Open
Open
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Oct 19, 2024

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@bencodezen bencodezen bencodezen approved these changes

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker area: docs Related to the documentation target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

Backlog

Development

Successfully merging this pull request may close these issues.

4 participants

@JeanMeche @marcosebsilva @pkozlowski-opensource @bencodezen