Skip to content

docs: Add mention to ENVIRONMENT_INITIALIZER#57464

Closed
JeanMeche wants to merge 1 commit intoangular:mainfrom
JeanMeche:docs/ENVIRONMENT_INITIALIZER
Closed

docs: Add mention to ENVIRONMENT_INITIALIZER#57464
JeanMeche wants to merge 1 commit intoangular:mainfrom
JeanMeche:docs/ENVIRONMENT_INITIALIZER

Conversation

@JeanMeche
Copy link
Member

Explicitly mention that ENVIRONMENT_INITIALIZER should not be async.

@JeanMeche JeanMeche requested a review from JoostK August 20, 2024 20:32
@pullapprove pullapprove bot requested a review from devversion August 20, 2024 20:32
@JeanMeche JeanMeche added adev: preview area: docs Related to the documentation labels Aug 20, 2024
@ngbot ngbot bot added this to the Backlog milestone Aug 20, 2024
@github-actions
Copy link

github-actions bot commented Aug 20, 2024

Deployed adev-preview for dfe33cf to: https://ng-dev-previews-fw--pr-angular-angular-57464-adev-prev-frl2u3hi.web.app

Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does adev have any "note" styling capabilities? And can APP_INITIALIZER be a link to its reference page?

Copy link
Member Author

@JeanMeche JeanMeche Aug 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cross linking will be enabled when #57346 lands !

The automatic styling is only available on the guide pages right now. For API entries we'll need to use <div class="alert is-helpful">

Copy link
Member Author

@JeanMeche JeanMeche Aug 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I stand corrected, the div trick did work on aio, but doesn't on adev.
I'll look into making both NOTE and the div work for API pages.

@JeanMeche JeanMeche force-pushed the docs/ENVIRONMENT_INITIALIZER branch from 4a464d9 to d221159 Compare August 20, 2024 21:24
Explicitly mention that `ENVIRONMENT_INITIALIZER` should not be async.
@JeanMeche JeanMeche force-pushed the docs/ENVIRONMENT_INITIALIZER branch from d221159 to dfe33cf Compare August 20, 2024 21:50
@JeanMeche JeanMeche removed the request for review from devversion August 20, 2024 21:51
@JeanMeche JeanMeche added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Aug 20, 2024
@AndrewKushnir
Copy link
Contributor

This PR was merged into the repository by commit 641f8f1.

The changes were merged into the following branches: main, 18.2.x

AndrewKushnir pushed a commit that referenced this pull request Aug 29, 2024
Explicitly mention that `ENVIRONMENT_INITIALIZER` should not be async.

PR Close #57464
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker adev: preview area: docs Related to the documentation target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants