refactor(migrations): leverage tsurge for signal input migration#57451
Closed
devversion wants to merge 3 commits intoangular:mainfrom
Closed
refactor(migrations): leverage tsurge for signal input migration#57451devversion wants to merge 3 commits intoangular:mainfrom
devversion wants to merge 3 commits intoangular:mainfrom
Conversation
…s more info * Improves some of the generic assignability for tsurge. Anything is allowed to be returned from an overridden `prepareProgram` method. This is useful for the signal input migration. * Passes the absolute root paths to migrations. This is helpful for the signal input migration and there is no other way to access it. It's better to pass specifically, compared to passing the whole unsafe `ParsedConfiguration` object.
This commit simplifies the batching support for the signal input migration by using the new tsurge framework we've built. This allows for consistent setup across all possible entry-points and also simplifies the 1P setup given that we can simply use the Tsurge macros, instead of having to maintain our own Go-based runner.
crisbeto
approved these changes
Aug 19, 2024
Contributor
|
This PR was merged into the repository by commit 270fb83. The changes were merged into the following branches: main, 18.2.x |
dylhunn
pushed a commit
that referenced
this pull request
Aug 20, 2024
…s more info (#57451) * Improves some of the generic assignability for tsurge. Anything is allowed to be returned from an overridden `prepareProgram` method. This is useful for the signal input migration. * Passes the absolute root paths to migrations. This is helpful for the signal input migration and there is no other way to access it. It's better to pass specifically, compared to passing the whole unsafe `ParsedConfiguration` object. PR Close #57451
dylhunn
pushed a commit
that referenced
this pull request
Aug 20, 2024
) This commit simplifies the batching support for the signal input migration by using the new tsurge framework we've built. This allows for consistent setup across all possible entry-points and also simplifies the 1P setup given that we can simply use the Tsurge macros, instead of having to maintain our own Go-based runner. PR Close #57451
dylhunn
pushed a commit
that referenced
this pull request
Aug 20, 2024
) This commit simplifies the batching support for the signal input migration by using the new tsurge framework we've built. This allows for consistent setup across all possible entry-points and also simplifies the 1P setup given that we can simply use the Tsurge macros, instead of having to maintain our own Go-based runner. PR Close #57451
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See individual commits.
Note: Most of the churn/diff in this PR is switching from one
ReplacementAPI to the other. Review can be focused more on themigration.tspart and batch/* changes. We can remove the 1P leftovers in a follow-up.